E2EE: Alternative implementation: allow setting key_ring_size and key_derivation_function (And add HKDF as a kdf)#921
Open
onestacked wants to merge 2 commits intolivekit:mainfrom
Conversation
This was referenced Feb 28, 2026
onestacked
force-pushed
the
EC-compat-changes-webrtc-change
branch
from
a15edf5 to
379961f
Compare
Author
|
Now based on webrtc-sdk/webrtc#224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less hacky alternative to #904
This PR uses
my webrtc-sdk PRthis webrtc-sdk PR to configure the KDF, instead of just overwriting the derived key afterwards. This should also now properly support KeyRatcheting.I've tested this with https://codeberg.org/esoteric_programmer/matrix-jukebox and it is compatible with ElementCall.
Fixed: #796