livekit: Bump rustls to 0.23 indirectly and allow consumer to provide TLS config#916
Open
kubkon wants to merge 3 commits intolivekit:mainfrom
Open
livekit: Bump rustls to 0.23 indirectly and allow consumer to provide TLS config#916kubkon wants to merge 3 commits intolivekit:mainfrom
kubkon wants to merge 3 commits intolivekit:mainfrom
Conversation
|
|
kubkon
force-pushed
the
push-wynlymml
branch
from
79cae95 to
8a5a327
Compare
Otherwise, when using livekit client SDK aka the `livekit` crate we are pulling in `webhooks` and `access-token` related functionality which really is not needed.
Author
|
FWIW here's a matching PR on our end: zed-industries/zed#50205 Thought it might be useful to showcase the intended use of the proposed changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch does two things:
rustlsto 0.23 used indirectly viatokio-tungstenitebumped to0.28andtokio-rustlsbumped to0.26tls_config: rustls::ClientConfigfield to the consumer inlivekit_api::signal_client::SignalOptionsandlivekit::room::RoomOptionswhich is then internally routed to theSignalStreamwhen configuring the connection; setting this option requires buildinglivekitwithsignal-client-tokioandrustls-tls-native-rootsfeatures enabledlivekit-apia little sincelivekitas a client SDK doesn't needwebhooksoraccess-tokenwhich ends up pulling in unnecessary deps such asjsonwebtokenand ends up conflicting with our use ofjsonwebtokenin other places in Zed - lemme know if that makes sense or if there is a better way!With this patch upstreamed, we could get rid of our fork over at Zed. Lemme know what you reckon!