fix the video track subscription in single pc mode#914
Open
xianshijing-lk wants to merge 6 commits intomainfrom
Open
fix the video track subscription in single pc mode#914xianshijing-lk wants to merge 6 commits intomainfrom
xianshijing-lk wants to merge 6 commits intomainfrom
Conversation
ladvoc
changed the title
ladvoc
reviewed
Feb 26, 2026
Contributor
ladvoc
left a comment
ladvoc
left a comment
There was a problem hiding this comment.
Fix looks good, just a few comments about how E2E tests are being handled.
| @@ -45,11 +45,16 @@ mod common; | |||
| mod signaling_tests { | |||
Contributor
There was a problem hiding this comment.
Integration tests do not need to be nested inside another module. You can move everything to the top-level of the file.
Contributor
There was a problem hiding this comment.
A helper for creating multiple room connections is already defined in common and used for all other tests—this should be reused here as well. Please see the implementation of the other E2E tests for example usage.
Contributor
Author
|
@ladvoc , please take another look. I should have already addressed your comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that was due to the DSP munging.
The PR will munge audio / video RTP headers.
Tests:
cargo test -p livekit --features "__lk-e2e-test,native-tls" \
--test peer_connection_signaling_test
test_v0_publish_ten_video_and_ten_audio_tracks
-- --nocapture --test-threads=1
cargo test -p livekit --features "__lk-e2e-test,native-tls" \
--test peer_connection_signaling_test
test_v1_publish_ten_video_and_ten_audio_tracks
-- --nocapture --test-threads=1