Skip to content

Store per sub-process memory stats for debugging @biglittlebigben biglittlebigben committed 25 minutes ago#1443

Merged
biglittlebigben merged 4 commits intomainfrom
benjamin/per_pid_memory_stats_details
Mar 6, 2026
Merged

Store per sub-process memory stats for debugging @biglittlebigben biglittlebigben committed 25 minutes ago#1443
biglittlebigben merged 4 commits intomainfrom
benjamin/per_pid_memory_stats_details

Conversation

@biglittlebigben
Copy link
Contributor

Also some refactoring to allow easier unit testing

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: 8a18722

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

require.NoError(t, err)

idle := st.GetCPUIdle()
require.GreaterOrEqual(t, 0.0, idle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - should this be?

require.GreaterOrEqual(t, idle, 0.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Used to require having the expected parameter first, but not the case here!

@biglittlebigben biglittlebigben merged commit 3241c3b into main Mar 6, 2026
9 checks passed
@biglittlebigben biglittlebigben deleted the benjamin/per_pid_memory_stats_details branch March 6, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants