Skip to content

Fix Accessibility Violations on Homepage #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Accessibility Violations on Homepage #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Link } from "gatsby"
import "../css/nav.css"

const Nav = ({ isFooter }) => (
<nav>
<nav aria-label={isFooter ? "Footer" : "Main"}>
<ul>
<li>
<Link to={"/"}>Home</Link>
Expand Down Expand Up @@ -38,4 +38,4 @@ const Nav = ({ isFooter }) => (
</ul>
</nav>
);
export default Nav;
export default Nav;
1 change: 1 addition & 0 deletions src/components/seo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const Seo = (props) => {

return (
<Helmet
htmlAttributes={{ lang: "en" }}
title={props.title}
meta={[
{
Expand Down
42 changes: 21 additions & 21 deletions src/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,26 @@ const renderPage = () => {
return (
<React.Fragment>
<Seo title="The Live Coders" />
<div id="hero">
<Header />
<h1>Learn to Code by Watching Us</h1>
<p>
Be a part of a growing community of coders, developers, and
technologists who love to stream their passions on Twitch.
</p>
<Link className="btn" to={"/applications"}>
Join Us
</Link>
<a
className="btn"
href="https://www.twitch.tv/team/livecoders"
target="_blank"
rel="noopener noreferrer"
>
Watch Us
</a>
</div>
<Header />
<main>
<div id="hero">
<h1>Learn to Code by Watching Us</h1>
<p>
Be a part of a growing community of coders, developers, and
technologists who love to stream their passions on Twitch.
</p>
<Link className="btn" to={"/applications"}>
Join Us
</Link>
<a
className="btn"
href="https://www.twitch.tv/team/livecoders"
target="_blank"
rel="noopener noreferrer"
>
Watch Us
</a>
</div>
<section id="missionStatement">
<div className="missionStatement__overlay"></div>
<div className="missionStatement__container">
Expand Down Expand Up @@ -178,7 +178,7 @@ const renderPage = () => {
<a href="https://fauna.com/" style={{ height: 90 }}>
<img
src={FaunaLogo}
alt=""
alt="Fauna"
style={{ width: 200, height: 90 }}
/>
</a>
Expand All @@ -192,7 +192,7 @@ const renderPage = () => {
<a href="https://manning.com" style={{ height: 90 }}>
<img
src={ManningLogo}
alt=""
alt="Manning Publications"
style={{ width: 200, marginTop: 30, marginBottom: 30 }}
/>
</a>
Expand Down