refactor: simplify device attribute assignment in print_device_info#1345
Merged
refactor: simplify device attribute assignment in print_device_info#1345
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 6 6
Lines 892 892
Branches 124 124
=======================================
Hits 891 891
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies how print_device_info in the example script defaults missing/empty device attributes to "N/A" by using the or operator, keeping the example code more concise while preserving behavior for empty strings.
Changes:
- Replace ternary-style fallback (
x if x else "N/A") withx or "N/A"fordevice.nameanddevice.version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request makes a small code simplification in the
print_device_infofunction. The change replaces the verbose conditional assignment with the more conciseoroperator for defaulting to "N/A" whendevice.nameordevice.versionare not set.