[rust] Lock rust version to specific nightly #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require a nightly build, but this makes CI fragile to breakage in the nightly release. Lock this to the latest known working version. This will have to be periodically revisited or as new features might be needed. Change-Id: I9d00fbe74d724402f7b3909d4fecba2d27d81d59
Contributor
Author
|
Not sure there is really a need to push this change separately, as it is included in #490. |
Member
|
Oh this is super helpful. Didn't know you could do that. Thanks! |
Contributor
Author
Well, I'm not sure I'd count it as "could do that", since github has no idea the changes are related to each other. But, as long as they have the same commit, if this merges first, it will just decide on a different base for the other change, and if that merged first, it would then consider this merged. It is nowhere close to how, for example, Gerrit tracks the commits. |
Member
|
Oh no I meant didn't know you could fix it to a specific version like that.
And it removes the +nightly flag which may have other consequences to cargo?
…On Wed, Dec 17, 2025 at 11:30 AM David Brown ***@***.***> wrote:
*d3zd3z* left a comment (littlekernel/lk#491)
<#491 (comment)>
Oh this is super helpful. Didn't know you could do that. Thanks!
Well, I'm not sure I'd count it as "could do that", since github has no
idea the changes are related to each other. But, as long as they have the
same commit, if this merges first, it will just decide on a different base
for the other change, and if that merged first, it would then consider this
merged.
It is nowhere close to how, for example, Gerrit tracks the commits.
—
Reply to this email directly, view it on GitHub
<#491 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAX3LDVHB3B7E47D5TE4H34CGVLVAVCNFSM6AAAAACPK22VXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRWHAZTSNJWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require a nightly build, but this makes CI fragile to breakage in the nightly release. Lock this to the latest known working version. This will have to be periodically revisited or as new features might be needed.
Change-Id: I9d00fbe74d724402f7b3909d4fecba2d27d81d59