Skip to content

Add lsquic_conn_get_full_cert_chain to obtain certs including leaf on server side#581

Open
richard-ramos wants to merge 1 commit intolitespeedtech:masterfrom
richard-ramos:full-cert-chain
Open

Add lsquic_conn_get_full_cert_chain to obtain certs including leaf on server side#581
richard-ramos wants to merge 1 commit intolitespeedtech:masterfrom
richard-ramos:full-cert-chain

Conversation

@richard-ramos
Copy link
Contributor

Adds an additional function to the API: lsquic_conn_get_full_cert_chain, which can be used when you want the client to send a certificate, and then perform a custom validation over the certificate sent by the client.

The reason behind why this function is necessary is because lsquic_conn_get_server_cert_chain will return the cert chain excluding the leaf when called from the server, and if the client is using a self signed certificate, the cert will just no appear there.

@dtikhonov
Copy link
Collaborator

Thank you for PR! Any chance you could add this call to bin/http_server.c? (It's fine if the answer is "no," but that will make this PR slower to merge, because then I will add this code to test...)

@richard-ramos
Copy link
Contributor Author

Sure! I'll update the PR today/tomorrow. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants