Conversation
Collaborator
Author
|
serve request that is erroring below: vllm serve meta-llama/Meta-Llama-3-8B-Instruct |
lisadunlap
reviewed
May 1, 2025
Owner
lisadunlap
left a comment
There was a problem hiding this comment.
looks good! Mostly minor things and making sure we are updating files instead of making new ones
Owner
There was a problem hiding this comment.
how does this differ from the get_differences.py file? If we are modifying that file let's name it the same thing so we don't muddy the repo
Collaborator
Author
There was a problem hiding this comment.
they actually are doing the same thing just checked now, I can change the name of mine nevertheless though
Owner
There was a problem hiding this comment.
can we instead update the existing utils_llm file
os error -- to take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.