fix: prevent mocks from matching after exceeded expect_at_most#225
Merged
Conversation
lipanski
reviewed
Feb 6, 2026
lipanski
reviewed
Feb 6, 2026
Abimael10
force-pushed
the
fix/expect-limit-matching
branch
from
841bd18 to
b16789d
Compare
Contributor
Author
|
Thank you very much for the feedback it makes total sense. I also updated some of the tests that were expected to fail after this change. |
lipanski
reviewed
Feb 15, 2026
lipanski
reviewed
Feb 15, 2026
lipanski
reviewed
Feb 15, 2026
lipanski
reviewed
Feb 15, 2026
Abimael10
force-pushed
the
fix/expect-limit-matching
branch
4 times, most recently
from
9380144 to
edc2bb9
Compare
lipanski
reviewed
Feb 21, 2026
Abimael10
force-pushed
the
fix/expect-limit-matching
branch
4 times, most recently
from
fb8901b to
d98880b
Compare
lipanski
reviewed
Feb 22, 2026
lipanski
reviewed
Feb 22, 2026
Abimael10
force-pushed
the
fix/expect-limit-matching
branch
from
d98880b to
c4560d6
Compare
Owner
|
|
🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent mocks from matching after exceeded expect_at_most. After this change, the assert on the bug is not passing.
Note: Left valid test --test_multiple_matched_mocks_with_expect_apply_in_order-- untouched (but adding my test below) to verify the fix, it now fails as it asserts the previous buggy behavior. Open to feedback on how you'd prefer the test updated.