fix: disable TTY for subprocess execution #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add disable_tty() to ExecCommand in both record and bash tool execution paths to prevent TTY-related issues when spawning subprocesses.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #170 +/- ##
==========================================
+ Coverage 47.59% 48.11% +0.52%
==========================================
Files 100 105 +5
Lines 27316 27916 +600
==========================================
+ Hits 13000 13433 +433
- Misses 14316 14483 +167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable TTY for subprocess execution to avoid TTY-related issues.
Changes
.disable_tty()call inrecordcommand.disable_tty()call inbashtoolBoth locations spawn subprocesses via
ExecCommandand need TTY disabled to ensure proper interaction behavior.