Skip to content

fix: preserve scroll-to-bottom when handling tool events #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linw1995 merged 1 commit into from
Jan 31, 2026
Merged

fix: preserve scroll-to-bottom when handling tool events #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/coco-tui/src/components/messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,10 @@ impl Messages {
*self.offset.write() = 0;
}

fn is_at_bottom(&self) -> bool {
self.offset.get() == 0
}

pub fn selected_idx(&self) -> Option<usize> {
self.focus.get()
}
Expand Down Expand Up @@ -616,6 +620,7 @@ impl Messages {

/// Returns the index in the vector of the tool message that handled the event.
pub fn on_tool_event(&mut self, event: &Event) -> Option<usize> {
let was_at_bottom = self.is_at_bottom();
match event {
Event::Ask(AskEvent::ToolUsePermission(id))
| Event::Ask(AskEvent::TextEdit { id, .. })
Expand All @@ -625,6 +630,9 @@ impl Messages {
if let Some(idx) = self.locate_tool_message(id) {
// Pass through the relative event to its component.
self.messages.write_untracked()[idx].handle_event(event);
if was_at_bottom {
self.scroll_to_bottom();
}
return Some(idx);
}
}
Expand Down Expand Up @@ -684,6 +692,10 @@ impl Messages {
let visible_end = visible_start.saturating_add(self.viewport_height);
let max_offset = self.total_height.saturating_sub(self.viewport_height);

if self.is_at_bottom() && idx + 1 == heights.len() && focus_bottom >= visible_end {
return;
}

let desired_top = if focus_top < visible_start {
focus_top
} else if focus_bottom > visible_end {
Expand Down