fix: improve exit control and subprocess handling #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are pending tool use or combo messages awaiting permission, Ctrl-C now focuses the first such message and triggers the exit confirmation flow instead of immediately exiting.
Create process groups for bash commands and use killpg to ensure all child processes are terminated when user cancels execution. Also separate user cancellation from error states and ensure double Ctrl-C uses the same shortcut key.
Ensure Ctrl-Q force quit checks the cancellation guard before triggering, consistent with other exit shortcuts.
linw1995
force-pushed
the
fix/cancel-exit-invalid
branch
from
6fa3205 to
7246b8a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #165 +/- ##
==========================================
+ Coverage 47.59% 47.87% +0.28%
==========================================
Files 100 104 +4
Lines 27316 27688 +372
==========================================
+ Hits 13000 13255 +255
- Misses 14316 14433 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves TUI exit control and subprocess termination:
Fixes
Changes
These changes ensure more reliable cancellation behavior and complete cleanup of subprocess resources.