Skip to content

Conversation

@linw1995
Copy link
Owner

Summary

Fix duplicate help shortcut hints by showing the appropriate key based on current focus state:

  • Input focused: Display Esc+? (require blur first)
  • Other focus: Display ? directly

Changes

  • Update decorate_block_top signature to accept is_input_focused parameter
  • Remove hardcoded help hint from input component
  • Dynamically render help key in shortcut hints panel based on focus state

Impact

  • coco-tui shortcut hints panel

Fixes duplicate hints and makes help guidance more accurate.

Remove the redundant help shortcut hint from the input component and dynamically display the correct help key based on focus state (Esc+? when input is focused, ? otherwise).
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.58%. Comparing base (a46f02c) to head (9c5653c).
⚠️ Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
crates/coco-tui/src/components/shortcut_hints.rs 0.00% 10 Missing ⚠️
crates/coco-tui/src/components/chat.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #160      +/-   ##
==========================================
- Coverage   50.22%   47.58%   -2.65%     
==========================================
  Files          93      100       +7     
  Lines       25033    27316    +2283     
==========================================
+ Hits        12574    12999     +425     
- Misses      12459    14317    +1858     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linw1995 linw1995 added the bug Something isn't working label Jan 29, 2026
@linw1995 linw1995 merged commit c3970cb into dev Jan 29, 2026
3 checks passed
@linw1995 linw1995 deleted the fix/duplicate-help-shortcuts branch January 29, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants