-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: move combo execution into CLI command with session socket support #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #150 +/- ##
==========================================
- Coverage 50.22% 47.04% -3.19%
==========================================
Files 93 98 +5
Lines 25033 27348 +2315
==========================================
+ Hits 12574 12865 +291
- Misses 12459 14483 +2024 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement Unix socket server for combo run session communication. Add bridge for managing active connections and forwarding combo events and results to external processes in real-time. Resolves #146
Implement `coco combo run` command that executes combos via session socket. Add support for spawning TUI process when no active session exists. Integrate ignore_workspace_scripts flag across CLI and TUI layers. Ensure COCO_TUI_BIN environment variable is set for proper subprocess handling. Resolves #147
Remove RunComboTool and convert combo execution to a built-in agent feature. - Add execute_combo_with_output method to Agent for direct combo execution - Update TUI to use task_combo_execute instead of tool-based execution - Remove run_combo from builtin tools list in agent.toml - Simplify combo execution by eliminating tool abstraction layer Resolves #148
12cc4d5 to
68e25cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
Summary
This PR implements the "RunCombo: move execution into coco combo run" enhancement by migrating combo execution from the
run_combotool to a dedicated CLI commandcoco combo runwith session socket integration.Key Changes
1. New CLI Command (
src/cmd/combo.rs)coco combo run <name> [args...]as the canonical entrypoint for combo executionCOCO_SESSION_SOCKis present2. Session Socket Protocol Extensions (
src/combo/session.rs)3. TUI Bridge Components (
crates/coco-tui/src/)combo_run_bridge.rs: Manages communication between CLI and TUI sessioncombo_run_server.rs: Session socket server handling combo run eventschat.rsandmessages/combo.rs: Enhanced to display streaming combo events4. Tool Integration
bashtool to injectCOCO_SESSION_SOCKwhen invokingcoco combo runrun_combotool5. Permission & Safety
Behavior
coco combo run demo a bstreams events to the TUI and returns JSON summarycoco combo runvia bash tool, with proper environment injection