-
Notifications
You must be signed in to change notification settings - Fork 729
feat: add category health score to project insights #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,11 @@ SQL > | |||||||||||||||||
| contributorDependencyCount, | ||||||||||||||||||
| contributorDependencyPercentage, | ||||||||||||||||||
| organizationDependencyCount, | ||||||||||||||||||
| organizationDependencyPercentage | ||||||||||||||||||
| organizationDependencyPercentage, | ||||||||||||||||||
| contributorPercentage, | ||||||||||||||||||
| popularityPercentage, | ||||||||||||||||||
| developmentPercentage, | ||||||||||||||||||
| securityPercentage | ||||||||||||||||||
| FROM health_score_copy_ds | ||||||||||||||||||
|
|
||||||||||||||||||
| NODE project_insights_copy_achievements | ||||||||||||||||||
|
|
@@ -106,6 +110,10 @@ SQL > | |||||||||||||||||
| COALESCE(dep.organizationDependencyPercentage, 0) AS organizationDependencyPercentage, | ||||||||||||||||||
| COALESCE(ach.achievements, []) AS achievements, | ||||||||||||||||||
| base.healthScore AS healthScore, | ||||||||||||||||||
| dep.contributorPercentage AS contributorHealthScore, | ||||||||||||||||||
| dep.popularityPercentage AS popularityHealthScore, | ||||||||||||||||||
| dep.developmentPercentage AS developmentHealthScore, | ||||||||||||||||||
| dep.securityPercentage AS securityHealthScore, | ||||||||||||||||||
|
Comment on lines
+113
to
+116
|
||||||||||||||||||
| dep.contributorPercentage AS contributorHealthScore, | |
| dep.popularityPercentage AS popularityHealthScore, | |
| dep.developmentPercentage AS developmentHealthScore, | |
| dep.securityPercentage AS securityHealthScore, | |
| if(isNaN(dep.contributorPercentage), null, dep.contributorPercentage) AS contributorHealthScore, | |
| if(isNaN(dep.popularityPercentage), null, dep.popularityPercentage) AS popularityHealthScore, | |
| if(isNaN(dep.developmentPercentage), null, dep.developmentPercentage) AS developmentHealthScore, | |
| if(isNaN(dep.securityPercentage), null, dep.securityPercentage) AS securityHealthScore, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description states these category scores are in the 0-100 range, but the schema marks them as
Nullable(Float64)and the upstream join can yield NULL (or even NaN if not sanitized). Consider updating the column docs to mention when NULL is expected (e.g., missing health score data), or alternatively make the pipe coalesce/sanitize and change the schema to non-nullable for clearer API semantics.