Skip to content

fix(slider): adjust path calculation for handle alignment #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
May 8, 2026
Merged

fix(slider): adjust path calculation for handle alignment #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions qt6/src/qml/Slider.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ T.Slider {
ArrowUp = 2,
ArrowLeft = 3,
ArrowBottom = 4,
ArrowRight = 5
ArrowRight = 5,
NoArrowType = 6
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
}

property D.Palette grooveColor: DS.Style.slider.groove.background
Expand Down Expand Up @@ -100,16 +101,29 @@ T.Slider {
startX: control.horizontal ? (control.alignToTicks ? __handle.width / 2 : 0) : sliderGroove.width / 2
startY: control.horizontal ? sliderGroove.height / 2 : sliderGroove.height
PathLine {
x: control.horizontal ? control.handle.x : sliderGroove.width / 2
y: control.horizontal ? sliderGroove.height / 2 : control.handle.y + control.handle.height / 2
x: control.horizontal ? (control.handleType === Slider.HandleType.NoArrowType
? control.visualPosition * sliderGroove.width
: control.handle.x) : sliderGroove.width / 2
y: control.horizontal ? sliderGroove.height / 2
: (control.handleType === Slider.HandleType.NoArrowType
? control.visualPosition * sliderGroove.height
: control.handle.y + control.handle.height / 2)
}
}

Item {
id: passItem
y: control.horizontal ? -DS.Style.slider.groove.height / 2 : control.handle.y + control.handle.height / 2
height: control.horizontal ? DS.Style.slider.groove.height : sliderGroove.height - control.handle.y - control.handle.height / 2
width: control.horizontal ? control.handle.x : DS.Style.slider.groove.height
y: control.horizontal ? -DS.Style.slider.groove.height / 2
: (control.handleType === Slider.HandleType.NoArrowType
? control.visualPosition * sliderGroove.height
: control.handle.y + control.handle.height / 2)
height: control.horizontal ? DS.Style.slider.groove.height
: (control.handleType === Slider.HandleType.NoArrowType
? sliderGroove.height - control.visualPosition * sliderGroove.height
: sliderGroove.height - control.handle.y - control.handle.height / 2)
width: control.horizontal ? (control.handleType === Slider.HandleType.NoArrowType
? control.visualPosition * sliderGroove.width
: control.handle.x) : DS.Style.slider.groove.height
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
}

BoxShadow {
Expand Down
Loading