-
Notifications
You must be signed in to change notification settings - Fork 88
feat: add DTK6 documentation package and improve build profiles #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1. Added new libdtk6core-doc package for DTK6 documentation with conditional build profile (!nodtk6 !nodoc) 2. Added new install file for libdtk6core-doc to install dtkcore.qch documentation 3. Reordered build dependencies: moved cmake to top and added conditional build profiles for Qt5/Qt6 tools and documentation 4. Updated debian/rules to enable BUILD_TESTING for both DTK5 and DTK6 builds 5. Modified DTK6 version check to use full DTK6_VERSION instead of MAJOR_MINOR for shared library versioning 6. Enabled BUILD_DOCS for DTK6 builds when documentation profile is active Log: Added separate documentation package for DTK6 Core library Influence: 1. Test building with different profiles (nodtk5, nodtk6, nodoc) to ensure conditional dependencies work correctly 2. Verify libdtk6core-doc package installation and documentation file placement 3. Test that BUILD_TESTING flag enables test builds properly 4. Verify shared library versioning uses correct version format for DTK6 5. Ensure backward compatibility with existing DTK5 packages feat: 添加DTK6文档包并改进构建配置 1. 新增libdtk6core-doc包用于DTK6文档,包含条件构建配置(!nodtk6 !nodoc) 2. 新增libdtk6core-doc安装文件以安装dtkcore.qch文档 3. 重新排序构建依赖:将cmake移至顶部,并为Qt5/Qt6工具和文档添加条件构建 配置 4. 更新debian/rules以同时为DTK5和DTK6构建启用BUILD_TESTING 5. 修改DTK6版本检查,使用完整DTK6_VERSION而非MAJOR_MINOR进行共享库版本 控制 6. 当文档配置激活时,为DTK6构建启用BUILD_DOCS Log: 为DTK6核心库新增独立的文档包 Influence: 1. 测试使用不同配置(nodtk5, nodtk6, nodoc)构建,确保条件依赖正常工作 2. 验证libdtk6core-doc包安装和文档文件放置位置 3. 测试BUILD_TESTING标志是否正确启用测试构建 4. 验证共享库版本控制对DTK6使用正确的版本格式 5. 确保与现有DTK5包的向后兼容性
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#529
deepin pr auto review我来对这个git diff进行详细的代码审查:
建议改进:
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
add_compile_options(-fsanitize=address -Wall -Wextra -Werror)
add_link_options(-fsanitize=address)
endif()
if (NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE Release CACHE STRING "Build type" FORCE)
endif()
mkdir -p build5
$(if $(wildcard build5),,$(error Failed to create build directory))
override_dh_auto_build:
# ... existing build commands ...
ifeq ($(BUILD_DOCS),ON)
@echo "Checking documentation quality..."
@! grep -r "TODO\|FIXME\|XXX" doc/ || (echo "Documentation contains TODO/FIXME markers"; exit 1)
endif这些改进可以提高代码质量、构建可靠性和文档质量。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| endif | ||
| ifeq ($(BUILD_DTK6),ON) | ||
| dh_makeshlibs -V "libdtk6core (>= $(DTK6_MAJOR_MINOR))" -plibdtk6core | ||
| dh_makeshlibs -V "libdtk6core (>= $(DTK6_VERSION))" -plibdtk6core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方和dtk5不一致了,是故意的吗。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是特意的,dtk6的需要三位版本兼容,dtk5的宽松些,
conditional build profile (!nodtk6 !nodoc)
documentation
conditional build profiles for Qt5/Qt6 tools and documentation
builds
MAJOR_MINOR for shared library versioning
active
Log: Added separate documentation package for DTK6 Core library
Influence:
ensure conditional dependencies work correctly
placement
feat: 添加DTK6文档包并改进构建配置
配置
控制
Log: 为DTK6核心库新增独立的文档包
Influence: