Skip to content

fix: remove redundant title label in dialog#300

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0521-fix-issue-362237
May 22, 2026
Merged

fix: remove redundant title label in dialog#300
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0521-fix-issue-362237

Conversation

@MyLeeJiEun
Copy link
Copy Markdown
Contributor

  1. Remove duplicated title Label from UpdateHistoryDialog since DialogWindow already displays the title in its title bar
  2. Remove duplicated title Label from UpdateLogDialog for the same reason
  3. Adjust layout constraints in UpdateLogDialog to properly fill content area without relying on fixed height

Log: Remove redundant title labels from update history and log dialogs

fix: 移除对话框中多余的标题标签

  1. 移除 UpdateHistoryDialog 中重复的标题 Label,DialogWindow 标题栏已显示标题
  2. 同理移除 UpdateLogDialog 中重复的标题 Label
  3. 调整 UpdateLogDialog 布局约束,不再依赖固定高度

Log: 移除更新历史和更新日志对话框中多余的标题标签
PMS: BUG-362237

@deepin-ci-robot
Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1. Remove duplicated title Label from UpdateHistoryDialog since
   DialogWindow already displays the title in its title bar
2. Remove duplicated title Label from UpdateLogDialog for the same reason
3. Adjust layout constraints in UpdateLogDialog to properly fill content
   area without relying on fixed height

Log: Remove redundant title labels from update history and log dialogs

fix: 移除对话框中多余的标题标签

1. 移除 UpdateHistoryDialog 中重复的标题 Label,DialogWindow 标题栏已显示标题
2. 同理移除 UpdateLogDialog 中重复的标题 Label
3. 调整 UpdateLogDialog 布局约束,不再依赖固定高度

Log: 移除更新历史和更新日志对话框中多余的标题标签
PMS: BUG-362237
@MyLeeJiEun MyLeeJiEun force-pushed the fork-from-master-0521-fix-issue-362237 branch from db11f14 to 935ba43 Compare May 22, 2026 01:31
@MyLeeJiEun
Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@MyLeeJiEun
Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot deepin-bot Bot merged commit e32d74c into linuxdeepin:master May 22, 2026
6 checks passed
@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 22, 2026

This pr cannot be merged! (status: unknown)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants