fix(info-dialog): remove window stays on top hint#289
Merged
deepin-bot[bot] merged 1 commit intoMay 8, 2026
Merged
Conversation
Remove Qt.WindowStaysOnTopHint flag from information dialog to allow normal window layering behavior. 移除信息对话框的窗口置顶标志,允许正常的窗口层级行为。 Log: 移除信息对话框窗口置顶标志 PMS: BUG-360103 Influence: 信息对话框不再强制置顶,用户可以正常操作其他窗口,提升用户体验。
deepin pr auto review这段代码修改了 QML 中 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合改进意见
优化后的代码建议: DialogWindow {
// ... 其他属性 ...
// 移除平台特定的 MSWindowsFixedSizeDialogHint,利用 width/minWidth/maxWidth 控制大小
// 移除 WindowStaysOnTopHint,依靠模态机制管理层级
flags: Qt.Dialog | Qt.WindowCloseButtonHint
// 确保模态性,防止用户在未关闭对话框时操作主窗口
modality: Qt.ApplicationModal
maximumWidth: 280
minimumWidth: 280
// 显式设置宽度,确保固定大小逻辑生效
width: 280
visible: false
// ...
}总结:原代码修改在语法上没有问题,主要是改变了窗口的层级行为。建议确认该对话框是否需要强制置顶,并检查 |
lzwind
approved these changes
May 8, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Qt.WindowStaysOnTopHint flag from information dialog to allow normal window layering behavior.
移除信息对话框的窗口置顶标志,允许正常的窗口层级行为。
Log: 移除信息对话框窗口置顶标志
PMS: BUG-360103
Influence: 信息对话框不再强制置顶,用户可以正常操作其他窗口,提升用户体验。