fix(window): prevent window re-centering on image switch#285
Merged
Conversation
lzwind
approved these changes
Apr 23, 2026
lzwind
previously approved these changes
Apr 23, 2026
Remove window centering from onCurrentSourceChanged to keep window position during image browsing. Center only once on startup. 移除 onCurrentSourceChanged 中的窗口居中逻辑,仅在程序首次 启动时居中窗口,切换和打开图片时保持用户摆放的位置。 Log: 修复切换图片时窗口位置重置到居中的问题 PMS: BUG-358647 Influence: 移动窗口后切换或打开图片不再跳回屏幕居中,仅在首次启动时居中。
deepin pr auto review这段代码的修改主要是对 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与改进建议这段改动主要是移除了切换文件时的自动窗口居中行为。 改进建议:
结论:该改动在语法和逻辑上是正确的,有助于提升用户体验(防止窗口跳动)和微小的性能提升。只要确保窗口初始化位置正确,这是一个合理的优化。 |
lzwind
approved these changes
Apr 23, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wyu71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only center window when opening new files via setImageFiles(), not on every currentSourceChanged during browsing.
仅在通过setImageFiles()打开新文件时居中窗口,
而非每次切换图片浏览时都重新居中。
Log: 修复切换图片时窗口位置重置到居中的问题
PMS: BUG-358647
Influence: 移动窗口后切换图片不再跳回屏幕居中,仅在首次打开图片文件时居中。