Skip to content

fix: add missing semicolon to Categories in desktop entry#203

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-366913-fix-desktop-categories-missing-semicolon
Jun 22, 2026
Merged

fix: add missing semicolon to Categories in desktop entry#203
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-366913-fix-desktop-categories-missing-semicolon

Conversation

@add-uos

@add-uos add-uos commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Categories field in desktop entry requires a trailing semicolon per the FreeDesktop specification.

修复desktop文件中Categories字段末尾缺少分号的问题。

Log: 修复desktop文件Categories缺少分号
PMS: https://pms.uniontech.com/bug-view-366913.html
Influence: 修复后desktop-file-validate不再报错,应用分类显示正确。

Summary by Sourcery

Bug Fixes:

  • Add the required trailing semicolon to the Categories field in the desktop entry to fix validation errors and incorrect category display.

Categories field in desktop entry requires a trailing semicolon
per the FreeDesktop specification.

修复desktop文件中Categories字段末尾缺少分号的问题。

Log: 修复desktop文件Categories缺少分号
PMS: https://pms.uniontech.com/bug-view-366913.html
Influence: 修复后desktop-file-validate不再报错,应用分类显示正确。
@sourcery-ai

sourcery-ai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the desktop entry's Categories field conforms to the FreeDesktop specification by adding a required trailing semicolon, fixing validation errors and category display issues.

File-Level Changes

Change Details Files
Add the required trailing semicolon to the Categories field in the desktop entry file to satisfy FreeDesktop specifications.
  • Update the Categories key value to include a trailing semicolon.
  • Ensure the modified desktop entry passes desktop-file-validate without errors and that the application category displays correctly in desktop environments.
deepin-font-manager-assets/deepin-font-manager.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

补全了 Desktop Entry 规范要求的末尾分号,修复精准且无副作用
逻辑完全正确且符合规范,无需扣分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

第2行将 Categories=Utility 修改为 Categories=Utility;,严格遵循了 freedesktop.org Desktop Entry Specification 中关于 Categories 键值必须以分号结尾的规范要求,消除了严格桌面环境解析器无法正确识别应用分类的隐患

  • 2.代码质量(符合规范)✓

修改点单一且针对性强,直接解决了规范不符合问题,没有引入多余更改或破坏原有配置结构

  • 3.代码性能(无性能问题)✓

作为静态的桌面入口配置文件,此修改仅在桌面环境初始化加载时进行一次字符串解析,对运行时性能无任何影响

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
修改仅涉及应用分类字符串的格式化补全,不涉及敏感信息暴露、权限控制变更或外部命令执行,无任何安全风险

■ 【改进建议代码示例】

diff --git a/deepin-font-manager-assets/deepin-font-manager.desktop b/deepin-font-manager-assets/deepin-font-manager.desktop
index f05f7c81..0b6fba25 100644
--- a/deepin-font-manager-assets/deepin-font-manager.desktop
+++ b/deepin-font-manager-assets/deepin-font-manager.desktop
@@ -1,5 +1,5 @@
 [Desktop Entry]
-Categories=Utility
+Categories=Utility;
 Exec=deepin-font-manager %F
 GenericName=Font Manager
 Icon=deepin-font-manager

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos

add-uos commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot deepin-bot Bot merged commit f15b76a into linuxdeepin:master Jun 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants