Skip to content

chore: update version to 6.5.40#202

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
wyu71:master
Jun 17, 2026
Merged

chore: update version to 6.5.40#202
lzwind merged 1 commit into
linuxdeepin:masterfrom
wyu71:master

Conversation

@wyu71

@wyu71 wyu71 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
  • bump version to 6.5.40

Log : bump version to 6.5.40

Summary by Sourcery

Chores:

  • Update linglong.yaml to set the package version to 6.5.40.1.

- bump version to 6.5.40

Log : bump version to 6.5.40
@sourcery-ai

sourcery-ai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the application package version metadata to 6.5.40.1 for the linglong configuration and aligns Debian packaging changelog accordingly.

File-Level Changes

Change Details Files
Bump application package version metadata to 6.5.40.1.
  • Update the linglong package version field from 6.5.39.1 to 6.5.40.1
  • Ensure Debian packaging changelog reflects the new 6.5.40 release information (content not fully shown in diff)
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.40
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 333968e into linuxdeepin:master Jun 17, 2026
17 of 20 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:65分

■ 【总体评价】

提交声称修复了字体误禁用的核心逻辑错误,但实际diff中完全缺失对应的C++源码修改
逻辑存在严重缺陷,因缺少核心修复代码导致BUG依然存在,属于致命非安全缺陷

■ 【详细分析】

  • 1.语法逻辑(存在严重错误)✕

diff中在debian/changelog声明了"fix: skip in-use font when disabling via D-Bus StandardFont query",但在整个diff中并未包含对关联模块DFontPreviewListView::disableFonts函数的任何修改,导致声称的修复逻辑完全未生效,属于严重的提交逻辑错误
潜在问题:系统当前字体仍会被误禁用,导致用户桌面字体显示异常或崩溃
建议:补充deepin-font-manager/interfaces/dfontpreviewlistview.cpp文件中针对ddeStandardFont的跳过校验逻辑

  • 2.代码质量(存在严重问题)✕

提交内容不完整,仅包含版本号升级和变更日志,缺乏核心业务代码变更,违反了代码提交的完整性和规范性
潜在问题:代码审查无法验证修复逻辑的正确性,导致带病版本可能被合入主干
建议:确保Git提交包含所有相关的源代码文件修改,避免仅提交配置和日志文件

  • 3.代码性能(无性能问题)✓

本次修改仅涉及debian/changelog和linglong.yaml两个纯文本配置文件,不引入任何额外的计算或系统调用开销
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次diff未包含任何可执行逻辑代码修改,未引入新的安全风险

  • 建议:在补充C++修复代码时,需注意D-Bus调用返回值的校验,防止空指针或无效字符串导致的越界问题

■ 【改进建议代码示例】

diff --git a/deepin-font-manager/interfaces/dfontpreviewlistview.cpp b/deepin-font-manager/interfaces/dfontpreviewlistview.cpp
index e72f4949..8599a519 100644
--- a/deepin-font-manager/interfaces/dfontpreviewlistview.cpp
+++ b/deepin-font-manager/interfaces/dfontpreviewlistview.cpp
@@ -1963,10 +1963,22 @@ void DFontPreviewListView::disableFonts(const QStringList &fontFiles)
 {
     // 通过 D-Bus 查询 DDE 外观服务设置的当前系统字体(放在锁外,避免同步 IPC 阻塞其他线程)
     QString ddeStandardFont;
+    QDBusReply<QString> reply;
     {
-        QDBusReply<QString> reply = QDBusInterface(
+        reply = QDBusInterface(
                                                 QStringLiteral("org.deepin.dde.Appearance1"),
+                                                QStringLiteral("/org/deepin/dde/Appearance1"),
+                                                QStringLiteral("org.deepin.dde.Appearance1"),
                                                 QStringLiteral("StandardFont")).call(QStringLiteral("Get"));
         if (reply.isValid())
             ddeStandardFont = reply.value().toString();
     }
+
+    // 校验并跳过系统当前正在使用的标准字体,防止误禁用导致系统界面异常
+    QStringList actualDisableList;
+    for (const QString &fontFile : fontFiles) {
+        if (!ddeStandardFont.isEmpty() && fontFile.contains(ddeStandardFont)) {
+            qDebug() << "Skip disabling in-use standard font:" << fontFile;
+            continue;
+        }
+        actualDisableList.append(fontFile);
+    }
+    // 后续使用 actualDisableList 进行禁用操作...
 }

@deepin-bot

deepin-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.40
  • Tag SHA: eca00658b44d506baecce886eafc0164dbc2ba7d
  • Commit SHA: 333968e174e908fca9d4855a947bbecda095f286
  • Tag Message:
    Release deepin-font-manager 6.5.40
    
    
  • Tagger:
    • Name: wyu71
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants