Skip to content

chore: Update version to 6.5.37#195

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:master
Mar 12, 2026
Merged

chore: Update version to 6.5.37#195
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev

@dengzhongyuan365-dev dengzhongyuan365-dev commented Mar 12, 2026

Copy link
Copy Markdown
Member
  • update version to 6.5.37

log: update version to 6.5.37

Summary by Sourcery

Bump the application package version metadata to 6.5.37.1.

- update version to 6.5.37

log: update version to 6.5.37
@sourcery-ai

sourcery-ai Bot commented Mar 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the application/package version from 6.5.36.1 to 6.5.37.1 in the primary packaging metadata, with a corresponding changelog update stubbed in debian/changelog.

File-Level Changes

Change Details Files
Update package version metadata to 6.5.37.1.
  • Change the package version field from 6.5.36.1 to 6.5.37.1 in the Linglong configuration
linglong.yaml
Prepare Debian packaging changelog for the new version.
  • Touch/update debian/changelog to reflect the new release version (no concrete diff shown)
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.37
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

这段代码变更主要涉及版本更新和变更日志的记录,以下是我的审查意见:

1. 语法逻辑

  • 版本号一致性debian/changelog 中记录的版本号是 6.5.37,而 linglong.yaml 中记录的版本号是 6.5.37.1
    • 问题:这两个文件中的版本号后缀不一致。通常 linglong.yaml 中的版本号用于构建包,而 changelog 用于记录变更历史。
    • 建议:请确认版本号策略。如果 linglong.yaml 需要包含构建号(如 .1),请确保这是符合项目规范的。如果 changelog 也应该反映构建号,则应同步更新。如果 changelog 仅记录上游版本,则当前状态可能可以接受,但建议在项目文档中明确这种差异的原因。

2. 代码质量

  • 变更日志格式debian/changelog 的格式符合 Debian 标准,包含了包名、版本、分发版、紧急度、维护者信息和变更条目。
    • 建议:变更条目 * refactor: Optimize font deletion process in DFontPreviewListView 写得比较清晰,使用了常见的 refactor: 前缀,这有助于区分变更类型(如 feat, fix, refactor 等)。
  • 日期有效性:日期显示为 Thu, 12 Mar 2026
    • 问题:年份 2026 是未来的时间。
    • 建议:请检查系统时间或提交时间,确保日期准确。虽然 Git 允许未来的日期,但这会导致版本排序混乱,且不符合常规发布流程。

3. 代码性能

  • 本变更仅涉及元数据文件(文本配置),不涉及执行代码,因此对运行时性能无直接影响。

4. 代码安全

  • 维护者邮箱:变更日志中包含了维护者的邮箱地址 dengzhongyuan@uniontech.com
    • 建议:确保这是公开的、用于接收维护相关邮件的邮箱。如果是内部邮箱或个人隐私邮箱,请考虑是否适合直接提交到公开的代码仓库中。
  • 版本号伪造:如果版本号管理不当(例如随意回退或大幅跳跃),可能导致依赖管理混乱或更新失败。
    • 建议:遵循严格的版本号递增策略(如语义化版本控制 SemVer),确保每次发布的版本号都是唯一且递增的。

总结与改进建议

这段变更本身格式正确,但存在两个主要问题需要修正:

  1. 修正日期:将 debian/changelog 中的日期从 2026 年修正为当前实际年份(如 20242025)。
  2. 统一版本号策略:明确 debian/changeloglinglong.yaml 中版本号的关系。通常建议保持主版本号一致,或者在构建系统中明确处理这种差异。

修正后的示例:

diff --git a/debian/changelog b/debian/changelog
index 334a0fd0..7ce33dc1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+deepin-font-manager (6.5.37.1) unstable; urgency=medium
+
+  * refactor: Optimize font deletion process in DFontPreviewListView
+
+ -- dengzhongyuan <dengzhongyuan@uniontech.com>  Thu, 12 Mar 2024 20:30:53 +0800
+
 deepin-font-manager (6.5.36) unstable; urgency=medium
 
   * chore: Unify linglong.yaml

(注:此处假设 linglong.yaml 的版本号 6.5.37.1 是正确的源,并将 changelog 同步为该版本号及当前年份)

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev

Copy link
Copy Markdown
Member Author

/merge

@deepin-bot deepin-bot Bot merged commit 3a2efbe into linuxdeepin:master Mar 12, 2026
17 checks passed
@deepin-bot

deepin-bot Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.37
  • Tag SHA: 921a2edcea341eb44211a5a232c9833a8edd7e75
  • Commit SHA: c76827143b7ad06ceeba582aa82f6728164c9686
  • Tag Message:
    Release deepin-font-manager 6.5.37
    
    
  • Tagger:
    • Name: dengzhongyuan365-dev
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants