Skip to content

chore: Bump version to 6.5.35#191

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr0204
Feb 4, 2026
Merged

chore: Bump version to 6.5.35#191
lzwind merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr0204

Conversation

@wangrong1069

@wangrong1069 wangrong1069 commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

As title.

Log: Bump version to 6.5.35

Summary by Sourcery

Chores:

  • Bump deepin-font-manager package version from 6.5.34.1 to 6.5.35.1 in all linglong.yaml manifests.

As title.

Log: Bump version to 6.5.35
@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.35
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai

sourcery-ai Bot commented Feb 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the application/package version from 6.5.34.1 to 6.5.35.1 across architecture-specific linglong manifests and Debian packaging metadata.

File-Level Changes

Change Details Files
Update application version in all linglong manifests for each supported architecture.
  • Change package.version from 6.5.34.1 to 6.5.35.1 in the root linglong.yaml manifest.
  • Change package.version from 6.5.34.1 to 6.5.35.1 in the arm64 architecture linglong.yaml manifest.
  • Change package.version from 6.5.34.1 to 6.5.35.1 in the loong64 architecture linglong.yaml manifest.
  • Change package.version from 6.5.34.1 to 6.5.35.1 in the mips64 architecture linglong.yaml manifest.
  • Change package.version from 6.5.34.1 to 6.5.35.1 in the sw64 architecture linglong.yaml manifest.
linglong.yaml
arm64/linglong.yaml
loong64/linglong.yaml
mips64/linglong.yaml
sw64/linglong.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

经过对提供的 git diff 输出进行审查,以下是从语法逻辑、代码质量、代码性能和代码安全四个方面的详细审查意见和改进建议:

1. 语法逻辑

  • 版本号一致性

    • 现状linglong.yaml 文件中的版本号已从 6.5.34.1 更新为 6.5.35.1,且在 arm64loong64mips64sw64 架构目录下均已同步更新。
    • 审查意见:逻辑正确。在多架构构建中,保持版本号同步是必要的,这避免了构建产物版本不一致的问题。
    • 建议:继续保持这种同步更新策略。
  • Changelog 格式

    • 现状debian/changelog 遵循了标准的 Debian 格式,包含了新版本号、发布级别、修改条目和签名信息。
    • 审查意见:格式符合规范。
    • 建议:无。

2. 代码质量

  • 版本控制与自动化

    • 现状:本次修改涉及 5 个不同架构下的 linglong.yaml 文件,修改内容完全一致(版本号变更)。
    • 审查意见:这种重复性的人工修改容易出错(例如漏改某个架构),且维护成本较高。
    • 建议:建议检查构建流程。是否可以通过构建脚本(如 CI/CD 流水线)在构建时自动注入版本号,或者使用符号链接/模板文件来生成不同架构的配置文件,从而减少手动维护多个重复文件的工作量。
  • Changelog 描述

    • 现状:描述中提到了 "separate Qt5/Qt6 build configurations" 和 "Update compiler flags"。
    • 审查意见:虽然 diff 中只展示了配置文件的版本变更,但 changelog 提到了代码层面的重大变更(编译器标志、Qt 版本分离)。
    • 建议:确保这些描述的变更确实已经提交到了代码库中。本次 diff 仅包含版本号变更,属于发布前的准备工作。

3. 代码性能

  • 配置文件性能
    • 现状:YAML 配置文件的变更仅涉及版本字符串的长度变化。
    • 审查意见:对性能无影响。解析器处理 "6.5.34.1" 和 "6.5.35.1" 的开销可以忽略不计。

4. 代码安全

  • 编译器标志更新

    • 现状:Changelog 中提到 "Update compiler flags for security enhancements"。
    • 审查意见:这是一个积极的信号。虽然 diff 中未展示具体的 CMakeLists.txtMakefile 变更,但更新编译器标志(如启用 -fstack-protector-strong, -D_FORTIFY_SOURCE=2 等)是提升二进制安全性的有效手段。
    • 建议
      1. 确认新增的编译器标志确实覆盖了所有架构(arm64, loong64, mips64, sw64)。
      2. 某些安全标志在不同架构或不同编译器版本(GCC vs Clang)上的行为可能不同,建议在 CI 中进行全架构的编译测试,确保不会引入兼容性问题。
      3. 如果使用了 Qt6,确保链接的 Qt6 库本身也是以相同安全级别编译的,以避免引入依赖漏洞。
  • 环境支持 (V20/V25)

    • 现状:Changelog 提到了 "Fix v20 env build issue"。
    • 审查意见:修复旧环境构建问题通常意味着兼容性补丁。
    • 建议:需确保为了兼容旧环境而添加的代码路径不会引入新的安全漏洞(例如废弃的 API 调用)。

总结

本次 diff 主要是为了发布新版本 6.5.35.1 而进行的配置文件同步更新,逻辑清晰,无明显错误。

主要改进建议集中在工程实践上

  1. 减少重复维护:考虑使用脚本或模板自动化生成多架构的 linglong.yaml,避免手动同步。
  2. 验证安全变更:既然 changelog 声称更新了编译器标志以增强安全性,请务必在合并后进行全架构的安全扫描(如使用 checksec 工具检查二进制文件),确认安全机制(如 RELRO, PIE, Stack Canary)已正确启用。

@lzwind lzwind merged commit 1435797 into linuxdeepin:master Feb 4, 2026
19 checks passed
@deepin-bot

deepin-bot Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.35
  • Tag SHA: 313b3aa332c2333ce220b48b7599b86f62d6ddbc
  • Commit SHA: 80f1206e3eb22f3a79be80933e43c7009a97c7e8
  • Tag Message:
    Release deepin-font-manager 6.5.35
    
    
  • Tagger:
    • Name: wangrong1069
  • Distribution: unstable

@wangrong1069 wangrong1069 deleted the pr0204 branch February 4, 2026 06:22
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants