Skip to content

chore: Bump version to 6.0.17#124

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr0521-2
May 21, 2026
Merged

chore: Bump version to 6.0.17#124
lzwind merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr0521-2

Conversation

@wangrong1069
Copy link
Copy Markdown
Contributor

@wangrong1069 wangrong1069 commented May 21, 2026

Summary

  • Update debian changelog for version 6.0.17 release
  • Includes fix: propagate SetPartitionLabel errors to installer layer

Test plan

  • Verify changelog format is correct
  • Verify version bump is consistent with code changes

Summary by Sourcery

Build:

  • Bump Debian package changelog to version 6.0.17, including notes for the SetPartitionLabel error propagation fix.

As title.

Log: Bump version to 6.0.17
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog to bump the package version to 6.0.17 and document the included fix for propagating SetPartitionLabel errors to the installer layer.

File-Level Changes

Change Details Files
Bump Debian package version and document the SetPartitionLabel error propagation fix.
  • Incremented the package version entry in debian/changelog to 6.0.17.
  • Added a changelog bullet describing the fix for propagating SetPartitionLabel errors to the installer layer.
  • Ensured the changelog entry follows existing formatting and release note conventions.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.0.17
EXISTED: no
DISTRIBUTION: unstable

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX。我已仔细审查了你提供的 Git Diff 内容。

本次提交是一个 Debian changelog 的更新,记录了版本号从 6.0.16 升级到 6.0.17,修复内容为:SetPartionLabel 的错误向上传播到安装程序层

针对本次代码变更,我将从语法逻辑、代码质量、代码性能和代码安全四个维度进行审查并给出改进意见:

1. 语法与逻辑

  • 拼写错误:在修复描述中,SetPartionLabel 存在拼写错误,正确的英文单词应为 Partition,建议改为 SetPartitionLabel。虽然这只是日志信息,不影响编译,但在后续通过日志排查问题时,统一且正确的命名有助于快速定位代码函数。
  • 日期格式合规性:changelog 中的日期格式为 Thu, 21 May 2026 21:58:37 +0800,符合 Debian changelog 的标准格式(即 day-of-week, dd month yyyy hh:mm:ss +zone),语法上没有问题。
  • 逻辑一致性(重要):changelog 声明将 SetPartionLabel 的错误向上传播。这意味着在对应的业务代码中,原本可能被忽略或仅打印日志的 error 现在被正确 return 了。请务必确保本次 commit 包含了实际的业务代码修改,而不仅仅是更新了 changelog,否则会导致代码行为与文档描述不符。

2. 代码质量

  • 变更描述的清晰度:当前的描述 propagate SetPartionLabel errors to installer layer 已经比较清晰地说明了“做了什么”,但为了进一步提升代码的可维护性,建议在提交信息或代码评审记录中补充“为什么这样做”。例如:如果忽略该错误会导致后续安装步骤使用错误的卷标导致失败,可以在长描述中补充这一点。
  • Debian 版本号规范:当前版本号为 6.0.17,没有添加后缀(如 ~rc1+deb11u1)。请确认这是正式发布版本还是日常构建版本。如果是向官方仓库提交,需确保版本号递增规则符合 Debian 的相关规范。

3. 代码性能

  • Changelog 变更不影响运行时性能:此 diff 仅涉及打包和发布元数据,不涉及运行时代码逻辑,因此对软件的运行时性能没有影响。
  • 业务代码侧的性能考量:虽然 diff 中未体现,但针对“错误向上传播”这一逻辑,需要提醒:在向上传播错误时,应避免因重试或复杂的错误包装(如深层次的 error wrapping)带来不必要的性能开销。如果是简单的 return err,则性能损耗可以忽略不计。

4. 代码安全

  • Changelog 本身无安全风险:该文件仅记录版本变更信息,不涉及敏感数据泄露或执行逻辑。
  • 业务代码侧的安全考量:关于 SetPartitionLabel 错误传播,在安全方面需要注意:
    • 错误信息脱敏:当错误传播到上层(尤其是 UI 层或前端展示层)时,确保不要将底层的系统错误信息(如包含磁盘路径 /dev/sda1、系统挂载点或内核错误详情)直接暴露给用户,以免被恶意用户利用进行路径探测或漏洞挖掘。
    • 状态一致性SetPartitionLabel 失败后向上传播错误,意味着流程中断。请确保在流程中断前,之前对磁盘进行的操作(如格式化、分区表修改)能够被安全回滚,否则会导致磁盘处于一个不一致的中间状态,甚至可能引发系统无法启动的严重安全问题。

综合改进建议

  1. 修正拼写:建议将 SetPartionLabel 修正为 SetPartitionLabel
  2. 检查关联代码:确保本次提交中包含了实际的 Go/C++(取决于项目语言)代码修改,真正实现了错误传播。
  3. 审查错误处理逻辑:检查业务代码中 SetPartitionLabel 返回错误后的清理逻辑,确保不会留下脏数据或导致磁盘状态不一致。

修改后的 Diff 示例:

diff --git a/debian/changelog b/debian/changelog
index 1f5359af..a8c900bd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+deepin-boot-maker (6.0.17) unstable; urgency=medium
+
+  * fix(disk): propagate SetPartitionLabel errors to installer layer
+
+ -- wangrong <wangrong@uniontech.com>  Thu, 21 May 2026 21:58:37 +0800
+
 deepin-boot-maker (6.0.16) unstable; urgency=medium
 
   * fix(disk): use temp file instead of shell pipe for fdisk input

如果你能提供对应的业务代码的 diff(即 SetPartitionLabel 所在函数的修改),我可以为你进行更深入的代码级审查!

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 9ced6eb into linuxdeepin:master May 21, 2026
21 of 23 checks passed
@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 21, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.17
  • Tag SHA: be193911ff125d470cdaadabaf265330f4f51e31
  • Commit SHA: 794fa5fa5b5304b0795c60cb9fc4bf4780e9bb6f
  • Tag Message:
    Release deepin-boot-maker 6.0.17
    
    
  • Tagger:
    • Name: wangrong1069
  • Distribution: unstable

@wangrong1069 wangrong1069 deleted the pr0521-2 branch May 22, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants