fix: compatibility with Qt 6.9+#1091
Conversation
QtWayland removed the method at qt/qtwayland@333bb80 This change follows layer-shell-qt's fix at KDE/layer-shell-qt@368cf2d
Reviewer's Guide by SourceryThis pull request addresses a compatibility issue with Qt versions 6.9 and later. The Sequence diagram for window exposure update in Qt 6.9+sequenceDiagram
participant Window
participant QWaylandLayerShellSurface
QWaylandLayerShellSurface->>Window: resizeFromApplyConfigure(m_pendingSize)
alt Qt Version < 6.9
Window->>Window: handleExpose(QRect(QPoint(), m_pendingSize))
else Qt Version >= 6.9
Window->>Window: updateExposure()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
建议的修改措施:
|
There was a problem hiding this comment.
Hey @felixonmars - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)instead of<in the#elifto improve readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Note that the project still fails to compile on Qt 6.9 with the patch, but the remaining error seems more likely a Qt bug: https://bugreports.qt.io/browse/QTBUG-135885 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, felixonmars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
QtWayland removed the method at
qt/qtwayland@333bb80
This change follows layer-shell-qt's fix at
KDE/layer-shell-qt@368cf2d
Summary by Sourcery
Update Qt compatibility for layer shell surface configuration to support Qt 6.9 and newer versions
Bug Fixes:
Enhancements: