Skip to content

fix: correct image references and add notification image#26

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:icon
Jul 18, 2025
Merged

fix: correct image references and add notification image#26
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:icon

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented Jul 18, 2025

  1. Fixed image reference format from ![[...]] to ![...] in multiple files
  2. Corrected case sensitivity in Screensaver.png reference
  3. Added new p_notification.png image for notification system
  4. Standardized image path references across all language versions
  5. Fixed broken image links in zh_HK and zh_TW documentation

fix: 修正图片引用并添加通知图片

  1. 将图片引用格式从![[...]]统一修正为![...]
  2. 修正了Screensaver.png的大小写问题
  3. 新增了p_notification.png通知系统图片
  4. 统一了所有语言版本的图片路径引用
  5. 修复了zh_HK和zh_TW文档中的图片链接问题

pms: BUG-324751

Summary by Sourcery

Fix various image reference issues in documentation, standardize asset path usage across locales, and add a new notification image asset

New Features:

  • Add p_notification.png asset for notification system

Bug Fixes:

  • Fix image reference syntax format, case sensitivity of screensaver image, and broken image links in zh_HK/zh_TW docs

Enhancements:

  • Standardize image path references across all language versions

1. Fixed image reference format from ![[...]] to ![...] in multiple
files
2. Corrected case sensitivity in Screensaver.png reference
3. Added new p_notification.png image for notification system
4. Standardized image path references across all language versions
5. Fixed broken image links in zh_HK and zh_TW documentation

fix: 修正图片引用并添加通知图片

1. 将图片引用格式从![[...]]统一修正为![...]
2. 修正了Screensaver.png的大小写问题
3. 新增了p_notification.png通知系统图片
4. 统一了所有语言版本的图片路径引用
5. 修复了zh_HK和zh_TW文档中的图片链接问题

pms: BUG-324751
@mhduiy mhduiy requested a review from 18202781743 July 18, 2025 10:14
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 18, 2025

Reviewer's Guide

This PR standardizes markdown image references across all language documentation by fixing syntax and paths, corrects the case for the Screensaver image in the English docs, and introduces a new notification image asset for the notification system.

File-Level Changes

Change Details Files
Standardize markdown image reference syntax and fix broken links across language docs
  • Replaced deprecated '![[...]]' syntax with proper '' in multiple markdown files
  • Unified empty alt-text image references to '' format
  • Resolved broken links in zh_HK, zh_TW, and zh_CN documentation
src/assets/dde/zh_HK/d_dde.md
src/assets/dde/zh_TW/d_dde.md
src/assets/dde/zh_CN/d_dde.md
src/assets/dde/zh_CN/p_dde.md
src/assets/dde/zh_HK/p_dde.md
src/assets/dde/zh_TW/p_dde.md
Correct case sensitivity for Screensaver image reference
  • Updated lowercase 'screensaver.png' to 'Screensaver.png' to match actual asset name
src/assets/dde/en_US/p_dde.md
Add new notification image asset
  • Introduced 'p_notification.png' for the notification system
src/assets/dde/common/p_notification.png

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes - here's some feedback:

  • Several image links use an empty alt tag (![](…)) after your changes—consider adding descriptive alt text for those to keep accessibility consistent.
  • I see p_notification.png added to assets but not referenced anywhere in the docs—please verify and integrate it where it’s meant to appear.
  • To prevent future casing or syntax drift, you could add a CI check or simple script that enforces the standardized image reference format and filename casing across all markdown files.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several image links use an empty alt tag (`![](…)`) after your changes—consider adding descriptive alt text for those to keep accessibility consistent.
- I see `p_notification.png` added to assets but not referenced anywhere in the docs—please verify and integrate it where it’s meant to appear.
- To prevent future casing or syntax drift, you could add a CI check or simple script that enforces the standardized image reference format and filename casing across all markdown files.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 4ea8f71 into linuxdeepin:master Jul 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants