chore: remove huangli and lunar calendar components#141
Merged
Conversation
Removed huangli database and generator along with lunar calendar functionality since the calendar now has built-in huangli support. This includes: 1. Deleted huangli-generator tool and its database files 2. Removed lunar-calendar service and related code 3. Updated Makefile and spec file to reflect these removals 4. Cleaned up no longer needed dependencies and configurations The removal was done because the system calendar now natively includes huangli data, making these separate components redundant and unnecessary for maintenance. chore: 移除黄历和农历日历组件 由于日历现已内置黄历支持，移除了黄历数据库和生成器以及农历日历功能。具体 包括： 1. 删除了huangli-generator工具及其数据库文件 2. 移除了lunar-calendar服务及相关代码 3. 更新了Makefile和spec文件以反映这些变更 4. 清理了不再需要的依赖项和配置 此次移除是因为系统日历现已原生包含黄历数据，使得这些独立组件变得冗余且无 需继续维护。
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review这个提交移除了与黄历（huangli）和农历（lunar-calendar）相关的代码和文件。具体来说，移除了以下内容：
这个改动可能会影响依赖于黄历和农历功能的应用程序。如果这些功能不再需要，那么这个改动是合理的。否则，应该评估移除这些功能的影响，并确保其他应用程序能够正常工作。 此外，移除的代码中包含了一些数据库操作和HTTP请求的代码，这些代码可能涉及到数据库连接和HTTP请求的关闭操作。在移除这些代码时，应该确保没有资源泄漏，例如数据库连接和HTTP请求没有被正确关闭。 最后，这个提交没有包含任何新的测试代码，因此无法评估移除这些功能后，代码的健壮性是否受到影响。建议在移除这些功能后，添加相应的测试代码，以确保代码的稳定性和可靠性。 |
Reviewer's GuideThis PR eliminates the standalone huangli-generator and lunar-calendar modules and updates build and packaging scripts accordingly, leveraging the calendar’s native huangli support. Entity relationship diagram for removed huangli databaseerDiagram
HUANGLI_DB {
int id
date date
string auspicious
string inauspicious
}
%% HUANGLI_DB table and its fields have been removed from the system.
Class diagram for removed huangli and lunar-calendar componentsclassDiagram
%% huangli-generator (removed)
class HuangliGenerator {
+main()
+request.go
}
%% huangli (removed)
class HuangliDB {
+Open()
+Query()
+Close()
}
%% lunar-calendar (removed)
class LunarCalendar {
+GetLunarDate()
+GetHuangliInfo()
+main()
}
class LunarCalendarManager {
+Load()
+Reload()
+Get()
}
HuangliGenerator --> HuangliDB : uses
LunarCalendar --> HuangliDB : queries
LunarCalendar --> LunarCalendarManager : managed by
%% All these classes and their relationships have been removed.
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
fly602
approved these changes
Jul 17, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed huangli database and generator along with lunar calendar functionality since the calendar now has built-in huangli support. This includes:
The removal was done because the system calendar now natively includes huangli data, making these separate components redundant and unnecessary for maintenance.
chore: 移除黄历和农历日历组件
由于日历现已内置黄历支持，移除了黄历数据库和生成器以及农历日历功能。具体
包括：
此次移除是因为系统日历现已原生包含黄历数据，使得这些独立组件变得冗余且无
需继续维护。
Summary by Sourcery
Remove deprecated huangli and lunar calendar components now covered by the system calendar
Build:
Chores: