Skip to content

fix: sku_customisation.service file should not be executable#84

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
dgchinner:sku-exec-fix
Feb 25, 2026
Merged

fix: sku_customisation.service file should not be executable#84
richm merged 1 commit intolinux-system-roles:mainfrom
dgchinner:sku-exec-fix

Conversation

@dgchinner
Copy link
Collaborator

@dgchinner dgchinner commented Feb 25, 2026

sku_customisation.service is a service unit file and should not be executable. systemd throws a warning about this on system startup. Fix the file permissions to get rid of the warning.

Issue Tracker Tickets (Jira or BZ if any): https://issues.redhat.com/browse/RHELHPC-164

Summary by Sourcery

Bug Fixes:

  • Correct systemd unit file permissions for sku_customisation.service from executable to standard read/write to stop systemd warnings on boot.

It is a service unit file and should not be executable. systemd
throws a warning about this on system startup. Fix the file
permissions to get rid of the warning.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 25, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the file permissions of the sku_customisation systemd unit file deployed by Ansible so it is no longer executable and avoids systemd startup warnings.

Flow diagram for deploying sku_customisation systemd unit with correct permissions

flowchart TD
    A[Ansible_task copy_sku_customisation_service] --> B[Copy sku_customisation.service to /etc/systemd/system/]
    B --> C[Set owner root]
    B --> D[Set group root]
    B --> E[Set mode 0644 non_executable]
    E --> F[systemd reads sku_customisation.service]
    F --> G[No executable_permission_warning at startup]
Loading

File-Level Changes

Change Details Files
Update deployed systemd unit file permissions to non-executable mode.
  • Change Ansible copy task mode from 0755 (executable) to 0644 (non-executable) for the sku_customisation.service unit file
  • Ensure resulting systemd unit under /etc/systemd/system is owned by root:root with appropriate read/write permissions only
tasks/main.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 6ff5c63 into linux-system-roles:main Feb 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants