Capture and display evmctl error messages and pass --v3 to evmctl when necessary#45
Capture and display evmctl error messages and pass --v3 to evmctl when necessary#45stefanberger wants to merge 3 commits into
Conversation
dc620d0 to
743b53f
Compare
Capture evmctl error message in err variable and display it if needed. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
743b53f to
0aa3d6c
Compare
There was a problem hiding this comment.
mkfs.ext4 fails with "8192-byte blocks too big for system (max 4096)" on most systems. An alternative would be to specify "-O ea_inode" on either the mkfs.ext4 or tune2fs commands.
mkfs.ext4 will pause and wait for user input - "Proceed anyway? (y,N)". In a non-interactive script, this causes the script to hang indefinitely. Possible solution is to pipe the letter "N" to the mkfs.ext4 command.
Please fix the mkfs.ext4 failure and how mkfs.ext4 handles failures.
mimizohar
left a comment
There was a problem hiding this comment.
In functions_kernel.sh, "err" is not defined as a local variable, nor displayed in this patch. Either define and use "err" or remove it from this patch.
Pass --v3 to evmctl when ML-DSA keys are used for signing. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
0aa3d6c to
5a5e272
Compare
Defining and using it now. |
Increase the ext4 block size to 8kb to not run out of space when trying to write ML-DSA signatures. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
5a5e272 to
bfa9e55
Compare
Capture and display evmctl error messages and pass --v3 to evmctl when ML-DSA keys are being used for signing.