Skip to content

Conversation

@santoshp210-akamai
Copy link
Contributor

@santoshp210-akamai santoshp210-akamai commented Dec 29, 2025

Description 📝

Notification Channel Type changes to accomodate the latest API specification and to support backward compatibility

Changes 🔄

List any change(s) relevant to the reviewer.

  • Modify the Notification Channel Types
  • Fix linting and type-checks to support the new types.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

NO UI Change

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

  • https://docs.google.com/document/d/1csUE83r_y1fnWOflAE9wMXLWuWWJIgWzdFZns3n3Bbk , check the Notification Channel Management APIs for reference
  • Example response from the API to support backward compatibility :
    { "pages": 1, "page": 1, "results": 4, "data": [ { "id": 10000, "label": "Read-Write Channel", "channel_type": "email", "type": "system", "content": { "email": { "email_addresses": [ "Users-with-read-write-access-to-resources" ] } }, "details": { "email": { "usernames": [], "recipient_type": "read_write_users" } }, "alerts": { "url": "/monitor/alert-channels/10000/alerts", "type": "alerts-definitions", "alert_count": 11 }, "created": "2025-09-04T07:48:14", "updated": "2025-12-18T05:39:00", "created_by": "system", "updated_by": "system" }, { "id": 10003, "label": "My User Email Channel", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10003/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-21T21:05:05", "updated": "2025-12-21T21:05:05", "created_by": "vagrant", "updated_by": "system" }, { "id": 10004, "label": "new custom alert", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10004/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-22T19:46:21", "updated": "2025-12-22T19:46:21", "created_by": "vagrant", "updated_by": "system" }, { "id": 10005, "label": "new custom alert 2", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10005/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-22T19:49:26", "updated": "2025-12-22T19:49:26", "created_by": "vagrant", "updated_by": "system" } ] }
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai santoshp210-akamai requested a review from a team as a code owner December 29, 2025 12:43
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 31, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing868 Passing11 Skipped43m 43s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
timerange-verification.spec.tsCloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » should implement and validate custom date/time picker for a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

@ankita-akamai
Copy link
Contributor

Merging as there are enough approvals and failures are unrelated!!

@ankita-akamai ankita-akamai merged commit cb8fb31 into linode:develop Jan 1, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants