Add support for Nodebalancers UDP #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
added
the
improvement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ezilber-akamai
force-pushed
the
TPT-3379-support-nodebalancers-udp
branch
from
0a25827 to
1c51a3f
Compare
ezilber-akamai
force-pushed
the
TPT-3379-support-nodebalancers-udp
branch
from
1912c19 to
fae511e
Compare
ezilber-akamai
force-pushed
the
TPT-3379-support-nodebalancers-udp
branch
from
fae511e to
fcfcd1b
Compare
ezilber-akamai
added
new-feature
ezilber-akamai
force-pushed
the
TPT-3379-support-nodebalancers-udp
branch
from
9b95bb0 to
06356a9
Compare
lgarber-akamai
approved these changes
Jan 14, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Works well on my end, great work!
lgarber-akamai
added a commit
that referenced
this pull request
May 27, 2025
* Add support for Nodebalancers UDP (#494) * Implemented changes for NodeBalancers UDP * Added unit tests * Fix lint * Fixed issue with cipher_suite in save * Lint * Addressed PR comments * Removed overriden _serialize method * Drop residual prints * Implement _serialize(...) override in NodeBalancerConfig (#555) * Add LA notice --------- Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com> Co-authored-by: Youjung Kim <126618609+ykim-1@users.noreply.github.com> Co-authored-by: Erik Zilber <ezilber@akamai.com> Co-authored-by: Youjung Kim <126618609+ykim-akamai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for Nodebalancers UDP and corresponding tests.
✔️ How to Test
Pull down this PR locally before running tests.
Unit Tests
make testunitIntegration Tests
make TEST_CASE="test_create_nb" testintmake TEST_CASE="test_get_nb_config_with_udp" testintmake TEST_CASE="test_update_nb_config" testintmake TEST_CASE="test_get_nb" testintmake TEST_CASE="test_update_nb" testint