Skip to content

Conversation

@jcallahan-akamai
Copy link
Contributor

📝 Description

This adds support for the POST /linode/instances/:id/firewalls/apply endpoint.

https://techdocs.akamai.com/linode-api/reference/post-apply-firewalls

✔️ How to Test

Code example:

    client = LinodeClient(os.getenv("LINODE_TOKEN"))

    # linode_id = YOUR LINODE ID

    linode = Instance(client, linode_id)
    linode.apply_firewalls() # Returns True if successful 

Integration test:

make TEST_CASE=test_linode_apply_firewall testint

Unit tests:

make testunit

@jcallahan-akamai jcallahan-akamai requested a review from a team as a code owner December 26, 2024 21:20
@jcallahan-akamai jcallahan-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team December 26, 2024 21:20
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, nice work!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM working locally!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pushed a commit to fix test image due to debain10 image being deprecated.

@lgarber-akamai lgarber-akamai merged commit 8e5134e into linode:dev Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants