Open
Conversation
Have to use no-build-isolation option for pip on a few integration tests because flake8-3.7.x depends on entrypoints that require flit in a build_system section of the toml file. We don't need that since we already have a package with flit-built setup.py. In future release of flake8 entrypoints are replaced with importlib-metadata, so this dependency will not cause us issues any more, but the no-build-isolation setting should be fine in the tests even in that case.
zvezdan
force-pushed
the
upgrade-flake8-to-3.7.9
branch
from
3737677 to
88ae58d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have to use no-build-isolation option for pip on a few integration tests
because flake8-3.7.x depends on entrypoints that require flit in a
build_system section of the toml file. We don't need that since we
already have a package with flit-built setup.py. In future release of
flake8 entrypoints are replaced with importlib-metadata, so this
dependency will not cause us issues any more, but the no-build-isolation
setting should be fine in the tests even in that case.