Open
Conversation
Tests cover the DataFrame API with start-snapshot-id / end-snapshot-id options for IncrementalAppendScan across both Spark versions: - Incremental read between two snapshots - Single snapshot range precision - Multi-snapshot spanning reads - Overwrite in range (Iceberg 1.2 rejects; 1.5 skips non-appends)
Tests the create_changelog_view stored procedure for CDC/incremental change tracking, available in Iceberg 1.5 (Spark 3.5 only): - Appends: verifies INSERT change types between snapshots - Overwrite: captures both DELETE (old rows) and INSERT (new rows) - Delete: verifies DELETE change type for removed rows (v2 format) - Net changes: collapses intermediate changes with identifier columns - Multi-snapshot span: changelog across multiple append snapshots
cdfb5f7 to
59493dc
Compare
Spark 3.1: use assertThrows for Iceberg 1.2 UnsupportedOperationException Spark 3.5: add IncrementalReadTest verifying Iceberg 1.5 skips non-appends
Validate exact row count, all change types/values for each id, and that unchanged id=2 does not appear. Fix misleading comment about net UPDATE when compute_updates is disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PoC validating that Iceberg's incremental read APIs work correctly on the OpenHouse stack. Users have asked about incrementally consuming data between snapshots for OH tables — this PR confirms the feature is supported and documents version-specific behavior and UX caveats.
Changes
New Features / Tests:
IncrementalReadTest.java(Spark 3.1 & 3.5) — testsIncrementalAppendScanvia the DataFrame API:UnsupportedOperationException; Iceberg 1.5 silently skips non-append snapshotsChangelogViewTest.java(Spark 3.5 only) — testscreate_changelog_viewstored procedure (Iceberg 1.4+):Key UX caveats for users:
IncrementalAppendScanis append-only; usecreate_changelog_viewfor overwrites/deletescreate_changelog_viewis only available on Spark 3.5 (Iceberg 1.5+)Testing Done
All tests pass:
Additional Information