Support for selectively demoting long to int in avro 1.9 to 1.11#593
Merged
li-ukumar merged 8 commits intolinkedin:masterfrom Oct 1, 2025
Merged
Support for selectively demoting long to int in avro 1.9 to 1.11#593li-ukumar merged 8 commits intolinkedin:masterfrom
li-ukumar merged 8 commits intolinkedin:masterfrom
Conversation
sandaar
reviewed
Sep 29, 2025
.../main/java/com/linkedin/avroutil1/compatibility/avro110/backports/GenericDatumReaderExt.java
Show resolved
Hide resolved
...test/java/com/linkedin/avroutil1/compatibility/avro19/AvroCompatibilityHelperAvro19Test.java
Show resolved
Hide resolved
helper/helper-common/src/main/java/com/linkedin/avroutil1/compatibility/CustomDecoder.java
Show resolved
Hide resolved
...main/java/com/linkedin/avroutil1/compatibility/avro110/backports/SpecificDatumReaderExt.java
Show resolved
Hide resolved
...l-110/src/main/java/com/linkedin/avroutil1/compatibility/avro110/codec/ResolvingDecoder.java
Show resolved
Hide resolved
bipinparmar
reviewed
Sep 29, 2025
...main/java/com/linkedin/avroutil1/compatibility/avro110/backports/SpecificDatumReaderExt.java
Show resolved
Hide resolved
li-ukumar
reviewed
Sep 30, 2025
...der/tests/tests-allavro/src/test/java/com/linkedin/avroutil1/builder/SpecificRecordTest.java
Show resolved
Hide resolved
li-ukumar
reviewed
Sep 30, 2025
li-ukumar
reviewed
Sep 30, 2025
...mmon/src/main/java/com/linkedin/avroutil1/compatibility/backports/SpecificRecordBaseExt.java
Show resolved
Hide resolved
bipinparmar
reviewed
Sep 30, 2025
| /** | ||
| * Indicates whether this record has custom decoding support enabled. | ||
| * | ||
| * @return true if custom decoding is enabled, false otherwise |
There was a problem hiding this comment.
Isn't the class not enabled for custom decoding. It is always return false. Shouldn't the doc mention that it will return false.
...ain/java/com/linkedin/avroutil1/compatibility/avro110/parsing/ResolvingGrammarGenerator.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests added