Skip to content

Conversation

@justinlin-linkedin
Copy link
Collaborator

Summary

Add more logs to NettyRequest to show more errors when client closing the connections.

Testing Done

Just the log

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.81%. Comparing base (52ba813) to head (09cde72).
⚠️ Report is 341 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/github/ambry/rest/NettyMessageProcessor.java 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3196      +/-   ##
============================================
+ Coverage     64.24%   69.81%   +5.56%     
- Complexity    10398    12816    +2418     
============================================
  Files           840      930      +90     
  Lines         71755    79080    +7325     
  Branches       8611     9461     +850     
============================================
+ Hits          46099    55206    +9107     
+ Misses        23004    20933    -2071     
- Partials       2652     2941     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinlin-linkedin justinlin-linkedin merged commit 895372b into linkedin:master Feb 4, 2026
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/logs branch February 4, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants