Conversation
of strimzi yaml deployment via K8sYamlDeployer
e5cb406 to
fb5990d
Compare
fb5990d to
fb87857
Compare
ryannedolan
approved these changes
Mar 3, 2026
Collaborator
ryannedolan
left a comment
There was a problem hiding this comment.
Nice! Seems like we could get rid of nearly all of the controllers at this point.
| return null; | ||
| } | ||
|
|
||
| HoptimatorJdbcSchema schema = subSchemaPlus.unwrap(HoptimatorJdbcSchema.class); |
Collaborator
There was a problem hiding this comment.
I wonder if we should add a properties field to HoptimatorJdbcSchema at some point.
Collaborator
Author
There was a problem hiding this comment.
Yea we could, doesn't really save us much besides maybe some weird DataSource URL unwrapping. Ideally we'd make HoptimatorJdbcSchema aware of which underlying Driver a table came from (e.g. KafkaDriver) then we'd be able to simplify a lot of this logic to just check table types and fetch properties associated with a table instead of reconstructing a lot of it like we need to do here in each Deployer.
| /** | ||
| * Deployer for Kafka topics. Creates topics in the synchronous DDL hot path. | ||
| * | ||
| * <p>Implements {@link Validated} to pre-check partition constraints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds CREATE TABLE support for all existing Drivers with some shared utilities. Each module now includes the ability to create and delete tables as well as incorporates custom validation checks depending on Driver type.
!describecommand in Quidem to list out table schemas. This is similar to!describein Sqlline orselect ... from metadata."COLUMNS"but these both require loading all drivers then reconciling the query which the new!describein Quidem doesn't do.