-
Notifications
You must be signed in to change notification settings - Fork 1
Initial Beta System #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annopkdd
wants to merge
53
commits into
linemob:master
Choose a base branch
from
annopkdd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial all base system
Contributor
|
@criticalnooks Can you port this php function to python? /**
* @param Middleware[] $middlewareList
*
* @return callable
*/
function createExecutionChain(array $middlewareList)
{
$lastCallable = function () {
// the final callable is a no-op
};
while ($middleware = array_pop($middlewareList)) {
$lastCallable = function ($command) use ($middleware, $lastCallable) {
return $middleware->execute($command, $lastCallable);
};
}
return $lastCallable;
} |
MiddleWare - button_template_middleware - carousel_template_middleware - confirm_template_middleware - default_message_middleware - image_carousel_template_middleware - image_message_middleware - imagemap_send_message_middleware - location_message_middleware - sticker_message_middleware Structure - use dependency injection for middleware
change base_url ImageMapSendMessage
ImageMapSendMessage change base_url change link_uri
DefaultMessageMiddleware fix word
Contributor
|
👍 looks good! I thinks we need to small change to something like this (?) pseudo codeclass DefaultCommand():
property name = 'DefaultCommand'
property cmd = ''
property template = None
private event;
self. __init__(event):
self.event = event;
self.isValidCmd():
return self.cmd == self.event.input
class CommandA():
property name = 'CommandA'
property cmd = '/a'
property template = None
private event;
self. __init__(event):
self.event = event;
self.isValidCmd():
return self.cmd == self.event.input
class CommandB():
property name = 'CommandB'
property cmd = '/b'
property template = None
private event;
self. __init__(event):
self.event = event;
self.isValidCmd():
return self.cmd == self.event.input
class CommandRegistry():
private commands = []
def add(command):
self.commands.push(command)
def find(event):
for (self.commands as command) {
command = new command(event);
if (command.isValidCmd()) {
return command;
}
}
return new DefaultCommand(event);
# Usage
commandRegistry = new CommandRegistry();
commandRegistry.add(CommandA)
commandRegistry.add(CommandB)
# middleware
class MiddlewareX():
def execute(command):
if (command.name != 'CommandA') {
return;
}
# i want to tell this command to send vdo message
command.template = new VdoMessageTemplate(....);Command should have Abstract -- to handle common logic of commands.from abc import ABCMeta, abstractmethod
class Command:
__metaclass__ = ABCMeta
property event;
property template;
def setEvent(event):
self.event = event;
@abstractmethod
def isValidCmd(self): pass
class CommandA(Command):
property cmd
property name
def isValidCmd():
return self.cmd === self.event.input
# in CommandRegistry.find(event)
....
command = new CommandA()
command.setEvent(event)
.... |
- modify command object
AttributeError: 'HelloMiddleware' object has no attribute 'command'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do