Remove screenshots from online docs export.#952
Merged
PoignardAzur merged 3 commits intomainfrom May 8, 2025
Merged
Conversation
DJMcNab
approved these changes
May 8, 2025
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Seems like a reasonable solution. We should check that this doesn't stop docs building (our docs.rs check doesn't actually work for this macro, as I've discovered by building the docs locally)
| #[cfg(docsrs)] | ||
| // TODO - Re-enable this once we find a way to load screenshots that doesn't go against our | ||
| // storage quotas. | ||
| #[cfg(FALSE)] |
Member
There was a problem hiding this comment.
cfg(false) should be stable in 6 weeks!
Member
|
We should document this in ARCHITECTURE.md as well |
xStrom
reviewed
May 8, 2025
DJMcNab
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.