-
Notifications
You must be signed in to change notification settings - Fork 22
Autogenerate core_arch modules
#196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bc24ec6 to
a693e8d
Compare
|
Apologies for the churn; this should be actually ready for review now. The NEON intrinsics in stdarch are a mess to sort through. |
|
Perhaps we should discuss (either Zulip or next office hours) what to do with the |
Shnatsel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of testing improvements have been merged into main recently. Merging main into this branch and seeing CI pass would make me much more confident in the correctness of this PR.
| /// Generate the constructor for this architecture. | ||
| /// | ||
| /// x86 and aarch64 require runtime feature detection, so the constructor is unsafe. | ||
| /// wasm32 has static feature detection, so the constructor is safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aarch64 is guaranteed to have NEON and currently fearless_simd doesn't have any other Aarch64 levels other than baseline NEON. So this could actually be safe for now; making it unsafe is just for future-proofing.
|
I don’t think any of the core_arch stuff is tested in CI though, no? |
|
Only through high-level operations, I believe. So only a small subset. |
|
Aren't we using the intrinsics directly? I don't think we are running anything from |
|
Ah, nevermind then, I must have been mistaken |
I'm not sure where the
core_archmodules originally came from. Raph's comment says he copied them from Pulp, which doesn't seem to document how or where they were generated.This PR replaces them with new autogenerated versions, created by parsing the
stdarchcrate. I've added it as a submodule underfearless_simd_gen.I've chosen to make
core_archgeneration a separate subcommand in thefearless_simd_genbinary; I expect it to be run much less often, and want to allow people to regenerate the rest of the code without having to clone the (relatively heavy)stdarchrepo.I'm not sure how much utility
core_architself provides right now. The main reason for doing this is that I've embarked on a bit of a yak-shaving expedition: