fix: wait per-layer on drafter KV pool during cpu cache loadback#6
Open
LorrinWWW wants to merge 4 commits into
Open
fix: wait per-layer on drafter KV pool during cpu cache loadback#6LorrinWWW wants to merge 4 commits into
LorrinWWW wants to merge 4 commits into
Conversation
LorrinWWW
changed the title
LorrinWWW
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drafter attention was reading uninitialized KV from in-flight cpu cache loads because the drafter pool was missing
register_layer_transfer_counter(soget_key_buffernever waited per-layer); also reorders the draft-index H2D before the load_streamstart_eventso load_stream can't consume not-yet-ready indices.Test Plan