fix: load embed chart on generate & copy URL action in embed settings #19397
+80
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
764abe3 to
a7ce129
Compare
|
Your preview environment pr-19397 has been deployed with errors. |
Preview Environment🌐 URL: https://lightdash-preview-pr-19397.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
a7ce129 to
2ddb2b8
Compare
joaoviana
force-pushed
the
01-12-fix_can_view_underlying_data_in_non-cartesian_tiles_if_enabled_on_embedded_content
branch
from
0a63501 to
2ce9c45
Compare
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
2ddb2b8 to
df5b5e0
Compare
joaoviana
force-pushed
the
01-12-fix_can_view_underlying_data_in_non-cartesian_tiles_if_enabled_on_embedded_content
branch
from
2ce9c45 to
26da9e5
Compare
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
df5b5e0 to
b24822b
Compare
joaoviana
force-pushed
the
01-12-fix_can_view_underlying_data_in_non-cartesian_tiles_if_enabled_on_embedded_content
branch
from
26da9e5 to
56a6883
Compare
joaoviana
added
🖥 frontend
Graphite App
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
stevelikesmusic
approved these changes
Jan 14, 2026
Contributor
stevelikesmusic
left a comment
stevelikesmusic
left a comment
There was a problem hiding this comment.
Legend. THANK YOU for building this. One comment on how we source the chartUuid.
Not in this PR, but would we be able to have a preview for charts as well from the admin similar to dashboards?
Contributor
stevelikesmusic
left a comment
stevelikesmusic
left a comment
There was a problem hiding this comment.
One more comment I just noticed. Could we add a width to the container for the embedded chart route?
joaoviana
changed the base branch from
01-12-fix_can_view_underlying_data_in_non-cartesian_tiles_if_enabled_on_embedded_content
to
graphite-base/19397
joaoviana
force-pushed
the
graphite-base/19397
branch
from
56a6883 to
2909d34
Compare
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
b24822b to
fb26627
Compare
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
fb26627 to
64da989
Compare
Contributor
Author
|
on it @stevelikesmusic |
Contributor
Author
|
done: (same styles as the container for Dashboards) + some margin :) |
joaoviana
force-pushed
the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
from
64da989 to
21ad70c
Compare
Contributor
Author
Merge activity
|
joaoviana
deleted the
01-13-fix_load_embed_chart_on_generate_copy_url_action_in_embed_settings
branch
lightdash-bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
# [0.2336.0](0.2335.0...0.2336.0) (2026-01-14) ### Bug Fixes * can view underlying data in non-cartesian tiles if enabled on embedded content ([#19354](#19354)) ([2909d34](2909d34)) * creating charts from editing doesn't respect tabs ([#19430](#19430)) ([39ce72f](39ce72f)) * filter dashboard parameters by active tab tiles (V2) ([#19431](#19431)) ([096f847](096f847)) * load embed chart on generate & copy URL action in embed settings ([#19397](#19397)) ([fb839f6](fb839f6)) ### Features * populate SQL for additional metrics in Slack artifact blocks ([#19435](#19435)) ([c3fee67](c3fee67))
Collaborator
|
🎉 This PR is included in version 0.2336.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #ISSUE_NUMBER
Description:
Added support for embedding individual charts with dedicated URLs. This PR creates a new route for embedded charts (
/embed/:projectUuid/chart/:chartUuid) and updates the embed service to generate chart-specific URLs when the content type is a chart.The implementation includes:
This change allows for more granular embedding of specific charts rather than only embedding entire dashboards.