Feat: Improve KVStore values and page layout#74
Draft
jgryffindor wants to merge 1 commit intoliftedinit:mainfrom
Draft
Feat: Improve KVStore values and page layout#74jgryffindor wants to merge 1 commit intoliftedinit:mainfrom
jgryffindor wants to merge 1 commit intoliftedinit:mainfrom
Conversation
Updating kvstore values to use ExpandCode component and truncate to display 5KB with larger values. Wrapping kvstore data table in box to set to 90% viewport height and introduce a scrollable box. This mitigates an issue with the left sidebar nav background being duplicated.
✅ Deploy Preview for lifted-gwen ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 29.15% 28.78% -0.37%
==========================================
Files 61 62 +1
Lines 1012 1025 +13
Branches 208 214 +6
==========================================
Hits 295 295
- Misses 714 727 +13
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ExpandCode component to display truncated values and improve the display.
This mitigates an issue with the left sidebar nav background being duplicated (see before screenshot).
Description
Fixes # (issue)
Testing
Breaking Changes (if applicable)
None
Screenshots (if applicable)
Before:
After:
Checklist: