-
Notifications
You must be signed in to change notification settings - Fork 116
feat: upgrade wagmi to v3 #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey! This is your new endpoint: https://2c9ec98d.widget-wagmiv3.pages.dev |
|
Hey! This is your new endpoint: https://ebf693a7.widget-wagmiv3.pages.dev |
|
Hey! This is your new endpoint: https://775c7f3b.widget-wagmiv3.pages.dev |
|
Hey! This is your new endpoint: https://dac5455f.widget-wagmiv3.pages.dev |
|
Hey! This is your new endpoint: https://2362e734.widget-wagmiv3.pages.dev |
| "typescript": "^5.9.3" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@gemini-wallet/core": ">=0.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wagmi/connectors@7.0.2 includes a Gemini wallet connector (gemini.js) that imports from @gemini-wallet/core, and Next.js's bundler requires the resolution of all the static imports (peerDependenciesMeta.optional does not skip the import). For vite, it works fine without because of the lazy loading.
package.json
Outdated
| "overrides": { | ||
| "@wagmi/connectors": ">=7.0.0", | ||
| "@react-native-async-storage/async-storage": ">=2.2.0", | ||
| "@reown/appkit": ">=1.8.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walletconnect/ethereum-provider forces @reown/appkit 1.8.1
|
Hey! This is your new endpoint: https://31850346.widget-wagmiv3.pages.dev |
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-17090
Why was it implemented this way?
Now wallet connection SDKs become optional (users need to pass to Ethereum widget provider either true or custom config object).
Example of config:
NB: dynamic labs, privy-io, reown, connectkit, rainbowkit do not support wagmi v3 yet.
Checklist before requesting a review