Skip to content

Conversation

@effie-ms
Copy link
Contributor

@effie-ms effie-ms commented Dec 2, 2025

Which Jira task is linked to this PR?

https://lifi.atlassian.net/browse/LF-16927

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.

@effie-ms effie-ms self-assigned this Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Hey! This is your new endpoint: https://4153c547.widget-refactorch.pages.dev

@effie-ms effie-ms marked this pull request as ready for review December 2, 2025 14:04
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Hey! This is your new endpoint: https://343e9cde.widget-refactorch.pages.dev

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Hey! This is your new endpoint: https://002e972e.widget-refactorch.pages.dev

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Hey! This is your new endpoint: https://54fa8978.widget-refactorch.pages.dev

@effie-ms effie-ms requested a review from chybisov December 5, 2025 17:47
Comment on lines 34 to 41
const externalClient = externalWidgetConfig
? createClient({
...externalWidgetConfig.sdkConfig,
apiKey: externalWidgetConfig.apiKey,
integrator:
externalWidgetConfig.integrator ?? window?.location.hostname,
})
: undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be good to put this external client into some state and update it if something changes, to avoid creating it on every render when it is used externally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added memoization

@github-actions
Copy link

Hey! This is your new endpoint: https://33d76951.widget-refactorch.pages.dev

@chybisov chybisov added the v4 label Dec 16, 2025
@github-actions
Copy link

Hey! This is your new endpoint: https://002df545.widget-refactorch.pages.dev

@github-actions
Copy link

Hey! This is your new endpoint: https://143abdfa.widget-refactorch.pages.dev

@effie-ms effie-ms requested a review from chybisov December 23, 2025 15:31
@github-actions
Copy link

Hey! This is your new endpoint: https://efa06924.widget-refactorch.pages.dev

@chybisov chybisov merged commit cdb11ea into main Jan 6, 2026
1 check passed
@chybisov chybisov deleted the refactor-chains branch January 6, 2026 11:18
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Hey! This is your new endpoint: https://c7746f23.widget-refactorch.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants