-
Notifications
You must be signed in to change notification settings - Fork 116
refactor: chains fetching #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! This is your new endpoint: https://4153c547.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://343e9cde.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://002e972e.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://54fa8978.widget-refactorch.pages.dev |
| const externalClient = externalWidgetConfig | ||
| ? createClient({ | ||
| ...externalWidgetConfig.sdkConfig, | ||
| apiKey: externalWidgetConfig.apiKey, | ||
| integrator: | ||
| externalWidgetConfig.integrator ?? window?.location.hostname, | ||
| }) | ||
| : undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be good to put this external client into some state and update it if something changes, to avoid creating it on every render when it is used externally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added memoization
|
Hey! This is your new endpoint: https://33d76951.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://002df545.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://143abdfa.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://efa06924.widget-refactorch.pages.dev |
|
Hey! This is your new endpoint: https://c7746f23.widget-refactorch.pages.dev |
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-16927
Checklist before requesting a review