Skip to content

Conversation

@0xDEnYO
Copy link
Contributor

@0xDEnYO 0xDEnYO commented Jan 2, 2026

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

@lifi-action-bot lifi-action-bot marked this pull request as draft January 2, 2026 01:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 2, 2026

Walkthrough

This PR updates the TokenWrapper deployment address in deployments/stable.json, changes the configuration file reference for TokenWrapper's converter from networks.json to tokenconverters.json, and refactors the verifyContract function to retrieve verifier URLs from foundry.toml instead of using --chain flags.

Changes

Cohort / File(s) Summary
Deployment Configuration
deployments/stable.json, script/deploy/resources/deployRequirements.json
TokenWrapper address updated from 0x5f177F60802f798Aef5E3723fDCF27C172Ae6756 to 0x16a43D7db650c2B4D40484e4Ef29ab54B934A1C9; TokenWrapper converter configFileName changed from networks.json to tokenconverters.json for network-specific configuration resolution.
Verification Script Enhancement
script/helperFunctions.sh
verifyContract function refactored to retrieve verifier URLs from foundry.toml via getVerifierUrlFromFoundryToml, replace --chain flags with --verifier-url consistently across zkEVM and non-zkEVM paths, add validation/error handling for missing verifier URLs, introduce retry logic with delays, and enhance output logging for verification outcomes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

AuditRequired

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ⚠️ Warning The PR description is largely incomplete with critical sections missing or left blank, including the Jira task link, implementation rationale, and all reviewer checklists unchecked. Fill in the Jira task number, explain the implementation approach, confirm code review and audit status, and verify all security checklists before merging.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main objective: deploying TokenWrapper to stable. It clearly summarizes the primary change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deploy-tokenwrapper-stable

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xDEnYO 0xDEnYO marked this pull request as ready for review January 2, 2026 01:13
@0xDEnYO 0xDEnYO enabled auto-merge (squash) January 2, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants