Skip to content

[codex] Fix SSV verified operators header scoring#825

Open
skhomuti wants to merge 2 commits into
developfrom
codex/fix-ics-ssv-header-validation
Open

[codex] Fix SSV verified operators header scoring#825
skhomuti wants to merge 2 commits into
developfrom
codex/fix-ics-ssv-header-validation

Conversation

@skhomuti

Copy link
Copy Markdown
Contributor

What changed

  • Cleaned ics_assessment/experience/data/ssv-verified-operators.csv so it is a plain single-column address list without a header.
  • Updated sync_ssv_verified() to keep generating that no-header format via write_lines().
  • Added input address normalization through Web3.to_checksum_address(...).lower() at CLI/batch assessment boundaries, preserving fail-fast behavior for invalid user input.
  • Added a low-level read_csv_rows() warning when the first row looks header-like instead of address-like.
  • Updated tests for SSV scoring, batch input normalization, static prepared data, sync output, and the new warning behavior.

Why

The SSV verified operators artifact was headered with Address, but it is consumed as a raw address-list CSV by Experience and Humanity scoring. That allowed the header value to be treated like a scored SSV match in direct assessment flows.

Validation

  • ./venv/bin/python -m pytest ics_assessment/tests -q -> 79 passed
  • ./venv/bin/python -m compileall -q ics_assessment
  • git diff --check
  • ./venv/bin/python -m ics_assessment.main assess Address --discord no --x yes --human-passport-score 0 --lido-high-signal-score 0 --ssv-high-signal-score 0 fails fast with ValueError, as expected.

@skhomuti skhomuti marked this pull request as ready for review June 23, 2026 12:28
@skhomuti skhomuti requested a review from a team as a code owner June 23, 2026 12:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ebebc71ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ics_assessment/batch_process_forms.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant