[codex] Fix SSV verified operators header scoring#825
Open
skhomuti wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ebebc71ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ics_assessment/experience/data/ssv-verified-operators.csvso it is a plain single-column address list without a header.sync_ssv_verified()to keep generating that no-header format viawrite_lines().Web3.to_checksum_address(...).lower()at CLI/batch assessment boundaries, preserving fail-fast behavior for invalid user input.read_csv_rows()warning when the first row looks header-like instead of address-like.Why
The SSV verified operators artifact was headered with
Address, but it is consumed as a raw address-list CSV by Experience and Humanity scoring. That allowed the header value to be treated like a scored SSV match in direct assessment flows.Validation
./venv/bin/python -m pytest ics_assessment/tests -q->79 passed./venv/bin/python -m compileall -q ics_assessmentgit diff --check./venv/bin/python -m ics_assessment.main assess Address --discord no --x yes --human-passport-score 0 --lido-high-signal-score 0 --ssv-high-signal-score 0fails fast withValueError, as expected.