Skip to content

test: support CircuitBreaker migration on mainnet#823

Merged
skhomuti merged 1 commit into
mainfrom
codex/backport-circuit-breaker-tests
Jun 23, 2026
Merged

test: support CircuitBreaker migration on mainnet#823
skhomuti merged 1 commit into
mainfrom
codex/backport-circuit-breaker-tests

Conversation

@skhomuti

@skhomuti skhomuti commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Backports CircuitBreaker migration support from develop to main without pulling the full deployment refactor.

What Changed

  • Updated mainnet deploy and upgrade artifacts to expose the live CircuitBreaker.
  • Replaced active GateSeal deploy/grant steps in the deployment scripts with CircuitBreaker role grants.
  • Kept legacy GateSeal parsing/revoke paths only where they are still needed for old artifacts and migration context.
  • Updated fork fixtures and role invariants to expect the reseal manager plus the configured CircuitBreaker.
  • Added CircuitBreaker fork pause coverage for CSM, accounting, oracle, verifier, vetted gate, and ejector.
  • Made CircuitBreaker pause tests use the current pauser state directly, without calling heartbeat() in test setup.

Context

The scripts regression workflow executes the pending Dual Governance proposal on a mainnet fork before running staking-modules tests. main needs these test and deployment-script updates so the fork state matches the post-migration CircuitBreaker setup.

Validation

  • staking-modules CI is green on this PR.
  • scripts CSM regression workflow was dispatched against this branch and passed.

@skhomuti skhomuti force-pushed the codex/backport-circuit-breaker-tests branch from 062c51d to f297793 Compare June 22, 2026 19:18
@skhomuti skhomuti marked this pull request as ready for review June 22, 2026 19:43
@skhomuti skhomuti requested a review from a team as a code owner June 22, 2026 19:43
@skhomuti skhomuti requested review from dgusakov and madlabman June 22, 2026 19:43
@skhomuti skhomuti force-pushed the codex/backport-circuit-breaker-tests branch from f297793 to 623034e Compare June 23, 2026 05:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 623034e1dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/helpers/Fixtures.sol Outdated
@skhomuti skhomuti force-pushed the codex/backport-circuit-breaker-tests branch from 623034e to 265e746 Compare June 23, 2026 05:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 265e7464f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/fork/integration/CircuitBreaker.t.sol
@skhomuti skhomuti force-pushed the codex/backport-circuit-breaker-tests branch from 265e746 to 814c47a Compare June 23, 2026 06:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 814c47a14e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread script/fork-helpers/SimulateVote.s.sol
@skhomuti skhomuti force-pushed the codex/backport-circuit-breaker-tests branch from 814c47a to 5510dd1 Compare June 23, 2026 11:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5510dd1a69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread script/fork-helpers/SimulateVote.s.sol
Comment thread script/fork-helpers/SimulateVote.s.sol
@skhomuti skhomuti merged commit 824be82 into main Jun 23, 2026
6 checks passed
@skhomuti skhomuti deleted the codex/backport-circuit-breaker-tests branch June 23, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants